[Django] #28892: Fixed header height in the admin site

4 views
Skip to first unread message

Django

unread,
Dec 5, 2017, 12:09:22 PM12/5/17
to django-...@googlegroups.com
#28892: Fixed header height in the admin site
-----------------------------------------+------------------------
Reporter: Claude Paroz | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 2.0
Severity: Normal | Keywords: css
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
The new CSS rules for the admin header fixes the height to 40px. This is
not nice for users customizing the header content (branding, usertools,
userlinks blocks) with higher content. That content is then cut at 40px
too.

--
Ticket URL: <https://code.djangoproject.com/ticket/28892>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Dec 5, 2017, 1:26:41 PM12/5/17
to django-...@googlegroups.com
#28892: Fixed header height in the admin site may break custom layouts
-------------------------------+------------------------------------

Reporter: Claude Paroz | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution:
Keywords: css | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by Tim Graham):

* version: 2.0 => 1.9
* stage: Unreviewed => Accepted


Old description:

> The new CSS rules for the admin header fixes the height to 40px. This is
> not nice for users customizing the header content (branding, usertools,
> userlinks blocks) with higher content. That content is then cut at 40px
> too.

New description:

The
[https://github.com/django/django/commit/35901e64b043733acd1687734274553cf994511b#r26065458
CSS rule] for the admin header fixes the height to 40px. This is not nice


for users customizing the header content (branding, usertools, userlinks
blocks) with higher content. That content is then cut at 40px too.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/28892#comment:1>

Django

unread,
May 26, 2018, 4:56:23 AM5/26/18
to django-...@googlegroups.com
#28892: Fixed header height in the admin site may break custom layouts
-------------------------------+--------------------------------------
Reporter: Claude Paroz | Owner: Sara Heins
Type: Bug | Status: assigned

Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution:
Keywords: css | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by Sara Heins):

* status: new => assigned
* owner: nobody => Sara Heins


--
Ticket URL: <https://code.djangoproject.com/ticket/28892#comment:2>

Django

unread,
May 27, 2018, 8:09:36 AM5/27/18
to django-...@googlegroups.com
#28892: Fixed header height in the admin site may break custom layouts
-------------------------------+--------------------------------------
Reporter: Claude Paroz | Owner: Sara Heins
Type: Bug | Status: assigned
Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution:
Keywords: css | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by Sara Heins):

* has_patch: 0 => 1


Comment:

Pull request submitted: https://github.com/django/django/pull/9996

--
Ticket URL: <https://code.djangoproject.com/ticket/28892#comment:3>

Django

unread,
May 29, 2018, 9:53:10 PM5/29/18
to django-...@googlegroups.com
#28892: Fixed header height in the admin site may break custom layouts
-------------------------------+--------------------------------------
Reporter: Claude Paroz | Owner: Sara Heins
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution: fixed

Keywords: css | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"5008d59a2a8b9df09737fc05c9e343146a348a90" 5008d59a]:
{{{
#!CommitTicketReference repository=""
revision="5008d59a2a8b9df09737fc05c9e343146a348a90"
Fixed #28892 -- Allowed admin navbar height to expand if needed.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28892#comment:4>

Reply all
Reply to author
Forward
0 new messages