[Django] #31265: Bug in ModelAdmin.render_change_form()'s has_file_field check

9 views
Skip to first unread message

Django

unread,
Feb 12, 2020, 4:32:52 AM2/12/20
to django-...@googlegroups.com
#31265: Bug in ModelAdmin.render_change_form()'s has_file_field check
------------------------------------------------+------------------------
Reporter: Tatiana Vasilevskaya | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 2.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
`ModelAdmin.render_change_form()`'s `has_file_field` check instantiates a
formset form without calling `get_form_kwargs` in
`admin_formset.formset.form().is_multipart()` and thus might fail in case
of a customized `__init__` of the formset form (designed to be used with
the customized `get_form_kwargs`). Cherry-pick of
https://github.com/django/django/commit/7c3a8b9db2ccfbb247732ce6726ab8dc11eff34d
into 2.2.x fixes the problem.

--
Ticket URL: <https://code.djangoproject.com/ticket/31265>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Feb 12, 2020, 4:38:58 AM2/12/20
to django-...@googlegroups.com
#31265: Bug in ModelAdmin.render_change_form()'s has_file_field check.
-------------------------------------+-------------------------------------
Reporter: Tatiana | Owner: nobody
Vasilevskaya |
Type: Bug | Status: closed
Component: contrib.admin | Version: 2.2
Severity: Normal | Resolution: invalid

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* status: new => closed
* resolution: => invalid


Comment:

Thanks for ticket, however Django 2.2 is in extended support so it doesn't
receive bugfixes anymore (except for security fixes and data loss bugs).

--
Ticket URL: <https://code.djangoproject.com/ticket/31265#comment:1>

Django

unread,
Dec 23, 2020, 5:15:00 AM12/23/20
to django-...@googlegroups.com
#31265: Bug in ModelAdmin.render_change_form()'s has_file_field check.
-------------------------------------+-------------------------------------
Reporter: Tatiana | Owner: nobody
Vasilevskaya |
Type: Bug | Status: closed
Component: contrib.admin | Version: 2.2
Severity: Normal | Resolution: invalid

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Carlton Gibson <carlton@…>):

In [changeset:"3a0ed0ce3f2e38c4336da6d68d901c6f3d5926dc" 3a0ed0ce]:
{{{
#!CommitTicketReference repository=""
revision="3a0ed0ce3f2e38c4336da6d68d901c6f3d5926dc"
Refs #31265 -- Updated .eslintignore to match eslint tests
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31265#comment:2>

Reply all
Reply to author
Forward
0 new messages