[Django] #21613: Misleading hardcoded input id in tutorial
Django
------------------------------------------------+------------------------
Reporter: claudep | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
https://docs.djangoproject.com/en/dev/intro/tutorial04/
''That means, when somebody selects one of the radio buttons and submits
the form, it’ll send the POST data choice=3.''
Apparently, nothing forces the value to be 3. We should rephrase this
sentence.
--
Ticket URL: <https://code.djangoproject.com/ticket/21613>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: claudep | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by claudep):
Oh, credit to Bruno Brouard for spotting this issue.
--
Ticket URL: <https://code.djangoproject.com/ticket/21613#comment:1>
Django
Reporter: claudep | Owner:
Type: | AnneTheAgile
Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by AnneTheAgile):
* owner: nobody => AnneTheAgile
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/21613#comment:2>
Django
Reporter: claudep | Owner:
Type: | AnneTheAgile
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by AnneTheAgile):
See Pull Request,
https://github.com/django/django/pull/2078
//My comment #21613 , Clarified the previously mysterious magic constant
'3'. I researched a bit and there are '3' default choices available,
https://docs.djangoproject.com/en/dev/intro/tutorial02/ .
--
Ticket URL: <https://code.djangoproject.com/ticket/21613#comment:3>
Django
Reporter: claudep | Owner:
Type: | AnneTheAgile
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"cc2d9602746395d5f406632139378d469ca6301b"]:
{{{
#!CommitTicketReference repository=""
revision="cc2d9602746395d5f406632139378d469ca6301b"
Fixed #21613 -- Removed a hardcoded input id from the tutorial.
Thanks Bruno Brouard for the report.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/21613#comment:4>
Django
Reporter: claudep | Owner:
Type: | AnneTheAgile
Cleanup/optimization | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"6980059af2835ed3d15b4a59e16321bc8d828c0e"]:
{{{
#!CommitTicketReference repository=""
revision="6980059af2835ed3d15b4a59e16321bc8d828c0e"
[1.5.x] Fixed #21613 -- Removed a hardcoded input id from the tutorial.
Thanks Bruno Brouard for the report.
Backport of cc2d960274 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/21613#comment:5>
Django
Reporter: claudep | Owner:
Type: | AnneTheAgile
Cleanup/optimization | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"07d3d57dedbc2baf8d704d32f3d48523d2991b9e"]:
{{{
#!CommitTicketReference repository=""
revision="07d3d57dedbc2baf8d704d32f3d48523d2991b9e"
[1.6.x] Fixed #21613 -- Removed a hardcoded input id from the tutorial.
Thanks Bruno Brouard for the report.
Backport of cc2d960274 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/21613#comment:6>
Django
Reporter: claudep | Owner:
Type: | AnneTheAgile
Cleanup/optimization | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by AnneTheAgile):
yay, I'm glad the fix is approved. I was thinking of just writing "#" as
done in the accepted change, but thought maybe it wouldn't be accepted and
so was trying to rewrite the text around it. I deleted my branch. Thank
you for your patience with me and question-answering !
--
Ticket URL: <https://code.djangoproject.com/ticket/21613#comment:7>