[Django] #22782: Add i18n to sitemap
Django
----------------------------------+---------------------------
Reporter: luanpab | Owner: luanpab
Type: New feature | Status: new
Component: contrib.sitemaps | Version: master
Severity: Normal | Keywords: sitemap, i18n
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 0
----------------------------------+---------------------------
Add I18n support to the Sitemap class, making it possible to have your
multiple language URLs in the sitemap.
--
Ticket URL: <https://code.djangoproject.com/ticket/22782>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: luanpab | Owner: luanpab
Type: New feature | Status: new
Component: contrib.sitemaps | Version: master
Keywords: sitemap, i18n | Triage Stage: Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timo):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
[https://github.com/django/django/pull/2767 PR is here]. (No need to
attach a patch, just link the PR).
--
Ticket URL: <https://code.djangoproject.com/ticket/22782#comment:1>
Django
Reporter: luanpab | Owner: luanpab
Type: New feature | Status: new
Component: contrib.sitemaps | Version: master
Keywords: sitemap, i18n | Triage Stage: Unreviewed
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by luanpab):
* needs_docs: 0 => 1
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/22782#comment:2>
Django
Reporter: luanpab | Owner: luanpab
Type: New feature | Status: new
Component: contrib.sitemaps | Version: master
Keywords: sitemap, i18n | Triage Stage: Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Changes (by luanpab):
* needs_docs: 1 => 0
* needs_tests: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/22782#comment:3>
Django
Reporter: luanpab | Owner: luanpab
Type: New feature | Status: new
Component: contrib.sitemaps | Version: master
Keywords: sitemap, i18n | Triage Stage: Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Comment (by luanpab):
Replying to [comment:3 luanpab]:
Sorry about that, I'm new at this ticket tracker. I haven't noticed you've
changed the options. Already changed it back.
Thank you.
--
Ticket URL: <https://code.djangoproject.com/ticket/22782#comment:4>
Django
Reporter: luanpab | Owner: luanpab
Type: New feature | Status: new
Component: contrib.sitemaps | Version: master
Keywords: sitemap, i18n | Triage Stage: Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Comment (by aaugustin):
I agree with the API proposed in the pull request. It just needs some
polish.
--
Ticket URL: <https://code.djangoproject.com/ticket/22782#comment:5>
Django
Reporter: luanpab | Owner: luanpab
Type: New feature | Status: new
Component: contrib.sitemaps | Version: master
Keywords: sitemap, i18n | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timo):
* needs_better_patch: 0 => 1
* stage: Unreviewed => Accepted
Comment:
I left comments for improvement on PR. Please uncheck "Patch needs
improvement" when you update it, thanks.
--
Ticket URL: <https://code.djangoproject.com/ticket/22782#comment:6>
Django
Reporter: luanpab | Owner: luanpab
Type: New feature | Status: new
Component: contrib.sitemaps | Version: master
Keywords: sitemap, i18n | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by luanpab):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/22782#comment:7>
Django
Reporter: luanpab | Owner: luanpab
Type: New feature | Status: new
Component: contrib.sitemaps | Version: master
Keywords: sitemap, i18n | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by luanpab):
I've updated the code and the diff file. Someone please delete the
"i18nsitemap.2.diff" attachment. I forgot to check the replace file check
box.
Thank you.
--
Ticket URL: <https://code.djangoproject.com/ticket/22782#comment:8>
Django
Reporter: luanpab | Owner: luanpab
Type: New feature | Status: closed
Component: contrib.sitemaps | Version: master
Severity: Normal | Resolution: fixed
Keywords: sitemap, i18n | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"407d070329b4df81dab488db35bb068976e3be43"]:
{{{
#!CommitTicketReference repository=""
revision="407d070329b4df81dab488db35bb068976e3be43"
Fixed #22782 -- Added i18n attr to Sitemap class
It makes possible to have your sitemap in multiple languages when
using i18n in URLs.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22782#comment:9>
Django
Reporter: luanpab | Owner: luanpab
Type: New feature | Status: closed
Component: contrib.sitemaps | Version: master
Severity: Normal | Resolution: fixed
Keywords: sitemap, i18n | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"3425d42bf1945a3e6b2562de6c71a614e6ab2845"]:
{{{
#!CommitTicketReference repository=""
revision="3425d42bf1945a3e6b2562de6c71a614e6ab2845"
Fixed test from refs #22782.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22782#comment:10>