[Django] #27028: Clarify failed parallel tests run message
Django
--------------------------------------+--------------------
Reporter: adamzap | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
If the test suite fails while running with more than one process, and the
traceback is cannot be pickled, this message is printed:
`You should re-run this test without the --parallel option to reproduce
the failure and get a correct traceback.`
The CPU count on my machine is 4, and the test suite runs with 4
processors if I don't provide the `--parallel` option or if I provide it
with no argument. So the message is misleading.
Perhaps the error message should say:
`You should re-run this test with the "--parallel 1" option to reproduce
the failure and get a correct traceback.`
I'll be happy to submit a PR if this ticket is accepted.
--
Ticket URL: <https://code.djangoproject.com/ticket/27028>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: adamzap | Owner: adamzap
Type: | Status: assigned
Cleanup/optimization |
Component: Testing framework | Version: master
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by adamzap):
* status: new => assigned
* needs_better_patch: => 0
* owner: nobody => adamzap
* needs_tests: => 0
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/27028#comment:1>
Django
Reporter: adamzap | Owner: adamzap
Type: Cleanup/optimization | Status: assigned
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by aaugustin):
* stage: Unreviewed => Accepted
Comment:
I believe this message can show up:
- when you run Django's test suite: runtests.py enables parallelization by
default
- when you run a project's test suite: parallelization isn't enabled by
default
The message is appropriate for the latter case but not for the former.
`--parallel=1` covers both use cases. That's a good solution.
--
Ticket URL: <https://code.djangoproject.com/ticket/27028#comment:2>
Django
Reporter: adamzap | Owner: adamzap
Type: Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by adamzap):
PR is here: https://github.com/django/django/pull/7037
Thanks!
--
Ticket URL: <https://code.djangoproject.com/ticket/27028#comment:3>
Django
Reporter: adamzap | Owner: adamzap
Type: Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by adamzap):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/27028#comment:4>
Django
Reporter: adamzap | Owner: adamzap
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"2a11d2d7a7d5c6609c85dbc631fad6b8a8645a64" 2a11d2d]:
{{{
#!CommitTicketReference repository=""
revision="2a11d2d7a7d5c6609c85dbc631fad6b8a8645a64"
Fixed #27028 -- Clarified failed parallel tests message.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27028#comment:5>
Django
Reporter: adamzap | Owner: adamzap
Type: Cleanup/optimization | Status: closed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"06ba4926115b50285497e88b51e2e6b2e1edcf49" 06ba4926]:
{{{
#!CommitTicketReference repository=""
revision="06ba4926115b50285497e88b51e2e6b2e1edcf49"
[1.10.x] Fixed #27028 -- Clarified failed parallel tests message.
Backport of 2a11d2d7a7d5c6609c85dbc631fad6b8a8645a64 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27028#comment:6>