[Django] #29536: SelectFilter2.js box resizing code has no effect
Django
-----------------------------------------+----------------------------
Reporter: Claude Paroz | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 2.0
Severity: Normal | Keywords: regression
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+----------------------------
SelectFilter2.js has some code to resize select boxes to the same height
in horizontal mode.
https://github.com/claudep/django/blob/78912ccd0e1fcdfe98ca85081c9eb8acb7aa1f6d/django/contrib/admin/static/admin/js/SelectFilter2.js#L166
Obviously this doesn't work any more. JS coder needed!
--
Ticket URL: <https://code.djangoproject.com/ticket/29536>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Claude Paroz | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 2.0
Keywords: regression | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz):
* Attachment "Capture d'écran de 2018-06-29 16-03-50.png" added.
What it used to look like
Django
Reporter: Claude Paroz | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 2.0
Keywords: regression | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz):
* Attachment "Capture d'écran de 2018-06-29 16-03-42.png" added.
Current look with size mismatch
Django
Reporter: Claude Paroz | Owner: Claude Paroz
Type: Bug | Status: assigned
Component: contrib.admin | Version: 2.0
Severity: Normal | Resolution:
Keywords: regression | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz):
* owner: nobody => Claude Paroz
* status: new => assigned
Comment:
I think I can handle this.
--
Ticket URL: <https://code.djangoproject.com/ticket/29536#comment:1>
Django
Reporter: Claude Paroz | Owner: Claude Paroz
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: regression | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------+----------------------------------------
Changes (by Claude Paroz):
* has_patch: 0 => 1
* ui_ux: 0 => 1
Comment:
[https://github.com/django/django/pull/10109 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/29536#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Claude
| Paroz
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: regression | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/29536#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Claude
| Paroz
Component: contrib.admin | Version: 2.0
Severity: Normal | Resolution: fixed
Keywords: regression | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz <claude@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"a5f139236f930df06ae0642507530ca98081e2a9" a5f13923]:
{{{
#!CommitTicketReference repository=""
revision="a5f139236f930df06ae0642507530ca98081e2a9"
Fixed #29536 -- Fixed SelectFilter2.js resizing to make boxes have equal
height.
Thanks Tim Graham for the review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29536#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Claude
| Paroz
Type: Bug | Status: closed
Severity: Normal | Resolution: fixed
Keywords: regression | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Claude Paroz <claude@…>):
In [changeset:"58a0a84c3817de94f1b108697b23b57f78d67425" 58a0a84c]:
{{{
#!CommitTicketReference repository=""
revision="58a0a84c3817de94f1b108697b23b57f78d67425"
[2.1.x] Fixed #29536 -- Fixed SelectFilter2.js resizing to make boxes have
equal height.
Thanks Tim Graham for the review.
Backport of a5f139236f930df06ae0642507530ca98081e2a9 from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29536#comment:5>