[Django] #28051: Index names are being overridden in ModelState

13 views
Skip to first unread message

Django

unread,
Apr 7, 2017, 8:40:46 AM4/7/17
to django-...@googlegroups.com
#28051: Index names are being overridden in ModelState
---------------------------------------------+------------------------
Reporter: Markus Holtermann | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: 1.11
Severity: Release blocker | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
---------------------------------------------+------------------------
Despite setting the `name` attribute in the constructor of the `Index`
class, the name is auto-generated in `ModelState`. This is unintentional
as that name will then end up in the database

--
Ticket URL: <https://code.djangoproject.com/ticket/28051>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 7, 2017, 8:43:20 AM4/7/17
to django-...@googlegroups.com
#28051: Index names are being overridden in ModelState
-------------------------------------+-------------------------------------
Reporter: Markus Holtermann | Owner: Markus
| Holtermann
Type: Bug | Status: assigned
Component: Migrations | Version: 1.11
Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Markus Holtermann):

* status: new => assigned
* owner: nobody => Markus Holtermann


--
Ticket URL: <https://code.djangoproject.com/ticket/28051#comment:1>

Django

unread,
Apr 7, 2017, 8:45:28 AM4/7/17
to django-...@googlegroups.com
#28051: Index names are being overridden in ModelState
-------------------------------------+-------------------------------------
Reporter: Markus Holtermann | Owner: Markus
| Holtermann
Type: Bug | Status: assigned
Component: Migrations | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Markus Holtermann):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/8328 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/28051#comment:2>

Django

unread,
Apr 7, 2017, 9:24:51 AM4/7/17
to django-...@googlegroups.com
#28051: Index names are being overridden in ModelState
-------------------------------------+-------------------------------------
Reporter: Markus Holtermann | Owner: Markus
| Holtermann
Type: Bug | Status: assigned
Component: Migrations | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/28051#comment:3>

Django

unread,
Apr 7, 2017, 11:48:02 AM4/7/17
to django-...@googlegroups.com
#28051: Index names are being overridden in ModelState
-------------------------------------+-------------------------------------
Reporter: Markus Holtermann | Owner: Markus
| Holtermann
Type: Bug | Status: closed
Component: Migrations | Version: 1.11
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"d3cf75ec6fbdd2c1f1bb1e6ccb48d4de1da2952b" d3cf75ec]:
{{{
#!CommitTicketReference repository=""
revision="d3cf75ec6fbdd2c1f1bb1e6ccb48d4de1da2952b"
Fixed #28051 -- Made migrations respect Index's name argument.

Thanks Marc Tamlyn for the report and Tim Graham for the review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28051#comment:4>

Django

unread,
Apr 7, 2017, 12:08:55 PM4/7/17
to django-...@googlegroups.com
#28051: Index names are being overridden in ModelState
-------------------------------------+-------------------------------------
Reporter: Markus Holtermann | Owner: Markus
| Holtermann
Type: Bug | Status: closed
Component: Migrations | Version: 1.11

Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"f9d2a20d7b6cbef24199332d28534e3e16fa20d9" f9d2a20d]:
{{{
#!CommitTicketReference repository=""
revision="f9d2a20d7b6cbef24199332d28534e3e16fa20d9"
[1.11.x] Fixed #28051 -- Made migrations respect Index's name argument.

Thanks Marc Tamlyn for the report and Tim Graham for the review.

Backport of d3cf75ec6fbdd2c1f1bb1e6ccb48d4de1da2952b from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28051#comment:5>

Reply all
Reply to author
Forward
0 new messages