[Django] #31766: GDALRaster: return self on transformation
Django
-------------------------------------+-------------------------------------
Reporter: Riccardo | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: GIS | Version: master
Severity: Normal | Keywords: GDALRaster; GIS
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
Currently the method GDALRaster.transform proceeds with the computation
even if the passed SRID is the same as the GDALRaster itself is in. I
would propose to just return self if a transformation like the following
is requested.
{{{
>> raster.srid
4326
>> raster.transform(4326)
}}}
This avoids unnecessary computation.
--
Ticket URL: <https://code.djangoproject.com/ticket/31766>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
--------------------------------------+------------------------------------
Reporter: Riccardo | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: GDALRaster; GIS | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by felixxm):
* stage: Unreviewed => Accepted
Comment:
Thanks, IMO it's expected to return `self.clone()` is such cases.
--
Ticket URL: <https://code.djangoproject.com/ticket/31766#comment:1>
Django
--------------------------------------+------------------------------------
Type: Cleanup/optimization | Status: new
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: GDALRaster; GIS | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Hasan Ramezani):
Does it need to implement `def clone` for `GDALRaster`? If so, should we
use `copy_ds` from `django.contrib.gis.gdal.prototypes` to copy the
`ds_input` and create a new `GDALRaster` object?
--
Ticket URL: <https://code.djangoproject.com/ticket/31766#comment:2>
Django
--------------------------------------+------------------------------------
Type: Cleanup/optimization | Status: new
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: GDALRaster; GIS | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Hasan Ramezani):
* cc: Hasan Ramezani (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/31766#comment:3>
Django
--------------------------------------+------------------------------------
Type: Cleanup/optimization | Status: new
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: GDALRaster; GIS | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by felixxm):
* cc: Daniel Wiesmann (added)
Comment:
> Does it need to implement `def clone` for `GDALRaster`?
Yes.
> If so, should we use `copy_ds` from `django.contrib.gis.gdal.prototypes`
to copy the `ds_input` and create a new `GDALRaster` object?
Probably, I'm not an expert.
--
Ticket URL: <https://code.djangoproject.com/ticket/31766#comment:4>
Django
Reporter: Riccardo | Owner: Srinivas
Type: | Reddy Thatiparthy
Cleanup/optimization | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: GDALRaster; GIS | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: nobody => Srinivas Reddy Thatiparthy
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/31766#comment:5>
Django
Reporter: Riccardo | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: GDALRaster; GIS | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Srinivas Reddy Thatiparthy):
* owner: Srinivas Reddy Thatiparthy => (none)
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/31766#comment:6>
Django
--------------------------------------+------------------------------------
Type: Cleanup/optimization | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: GDALRaster; GIS | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by bartonip):
* owner: (none) => bartonip
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/31766#comment:9>
Django
Reporter: Riccardo | Owner: bartonip
Type: | Status: assigned
Cleanup/optimization |
Component: GIS | Version: master
Keywords: GDALRaster; GIS | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
* stage: Accepted => Ready for checkin
Comment:
Patch submitted: https://github.com/django/django/pull/13365
--
Ticket URL: <https://code.djangoproject.com/ticket/31766#comment:10>
Django
-------------------------------------+-------------------------------------
Type: | Status: assigned
Cleanup/optimization |
Component: GIS | Version: master
Keywords: GDALRaster; GIS | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Ready for checkin => Accepted
Comment:
The PR should be first reviewed by reviewers and then they will change it
to [https://docs.djangoproject.com/en/dev/internals/contributing/triaging-
tickets/#ready-for-checkin Ready for checkin] Stage.
--
Ticket URL: <https://code.djangoproject.com/ticket/31766#comment:11>
Django
-------------------------------------+-------------------------------------
Reporter: Riccardo | Owner: Barton Ip
Type: | Status: assigned
Component: GIS | Version: master
Keywords: GDALRaster; GIS | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/31766#comment:12>
Django
-------------------------------------+-------------------------------------
Reporter: Riccardo | Owner: Barton Ip
Type: | Status: assigned
Component: GIS | Version: master
Keywords: GDALRaster; GIS | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/31766#comment:13>
Django
-------------------------------------+-------------------------------------
Reporter: Riccardo | Owner: Barton Ip
Type: | Status: assigned
Component: GIS | Version: master
Keywords: GDALRaster; GIS | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):
* easy: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/31766#comment:14>
Django
-------------------------------------+-------------------------------------
Reporter: Riccardo | Owner: Barton Ip
Cleanup/optimization |
Component: GIS | Version: master
Keywords: GDALRaster; GIS | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"12d6cae7c0401baa70c934f465bad856afecc847" 12d6cae]:
{{{
#!CommitTicketReference repository=""
revision="12d6cae7c0401baa70c934f465bad856afecc847"
Fixed #31766 -- Made GDALRaster.transform() return a clone for the same
SRID and driver.
Thanks Daniel Wiesmann for the review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31766#comment:15>