[Django] #24432: Documentation: M2M through attribute is underspecified

7 views
Skip to first unread message

Django

unread,
Mar 1, 2015, 4:37:09 PM3/1/15
to django-...@googlegroups.com
#24432: Documentation: M2M through attribute is underspecified
-------------------------------+--------------------
Reporter: marfire | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------
The
[[https://docs.djangoproject.com/en/dev/ref/models/fields/#django.db.models.ManyToManyField.through|documentation]]
says that the automatically created `through` attribute has fields named
`<containing_model>_id` and `<other_model>_id`.

That can't be true when it is a M2M to `self`, since `containing_model`
and `other_model` are the same. A quick test shows that the fields in that
case are named `from_<model>_id` and `to_<model>_id`. The documentation
should cover this case.

--
Ticket URL: <https://code.djangoproject.com/ticket/24432>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Mar 1, 2015, 11:51:03 PM3/1/15
to django-...@googlegroups.com
#24432: Documentation: M2M through attribute is underspecified
--------------------------------------+------------------------------------
Reporter: marfire | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by charettes):

* needs_docs: => 0
* needs_better_patch: => 0
* type: Bug => Cleanup/optimization
* needs_tests: => 0
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/24432#comment:1>

Django

unread,
Mar 7, 2015, 8:07:42 AM3/7/15
to django-...@googlegroups.com
#24432: Documentation: M2M through attribute is underspecified
--------------------------------------+------------------------------------
Reporter: marfire | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: afraid-to-commit | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by EvilDMP):

* keywords: => afraid-to-commit


--
Ticket URL: <https://code.djangoproject.com/ticket/24432#comment:2>

Django

unread,
Mar 7, 2015, 9:08:30 AM3/7/15
to django-...@googlegroups.com
#24432: Documentation: M2M through attribute is underspecified
--------------------------------------+------------------------------------
Reporter: marfire | Owner: Oxylo
Type: Cleanup/optimization | Status: assigned
Component: Documentation | Version: master

Severity: Normal | Resolution:
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Oxylo):

* status: new => assigned
* owner: nobody => Oxylo


--
Ticket URL: <https://code.djangoproject.com/ticket/24432#comment:3>

Django

unread,
Mar 7, 2015, 9:16:25 AM3/7/15
to django-...@googlegroups.com
#24432: Documentation: M2M through attribute is underspecified
--------------------------------------+------------------------------------
Reporter: marfire | Owner:
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master

Severity: Normal | Resolution:
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Oxylo):

* status: assigned => new
* owner: Oxylo =>


--
Ticket URL: <https://code.djangoproject.com/ticket/24432#comment:4>

Django

unread,
Mar 7, 2015, 9:59:12 AM3/7/15
to django-...@googlegroups.com
#24432: Documentation: M2M through attribute is underspecified
--------------------------------------+------------------------------------
Reporter: marfire | Owner: fdh
Type: Cleanup/optimization | Status: assigned
Component: Documentation | Version: master

Severity: Normal | Resolution:
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by fdh):

* owner: => fdh


* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/24432#comment:5>

Django

unread,
Mar 7, 2015, 1:29:02 PM3/7/15
to django-...@googlegroups.com
#24432: Documentation: M2M through attribute is underspecified
--------------------------------------+------------------------------------
Reporter: marfire | Owner: fdh
Type: Cleanup/optimization | Status: assigned
Component: Documentation | Version: master

Severity: Normal | Resolution:
Keywords: afraid-to-commit | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timgraham):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/4269 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/24432#comment:6>

Django

unread,
Mar 7, 2015, 2:47:44 PM3/7/15
to django-...@googlegroups.com
#24432: Documentation: M2M through attribute is underspecified
-------------------------------------+-------------------------------------
Reporter: marfire | Owner: fdh
Type: | Status: assigned
Cleanup/optimization |
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: afraid-to-commit | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by erikr):

* stage: Accepted => Ready for checkin


Comment:

Looks good to me!

--
Ticket URL: <https://code.djangoproject.com/ticket/24432#comment:7>

Django

unread,
Mar 9, 2015, 8:45:28 PM3/9/15
to django-...@googlegroups.com
#24432: Documentation: M2M through attribute is underspecified
-------------------------------------+-------------------------------------
Reporter: marfire | Owner: fdh
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed

Keywords: afraid-to-commit | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"b9b8411129efe13642cef1fc6bbfc62bed717352"]:
{{{
#!CommitTicketReference repository=""
revision="b9b8411129efe13642cef1fc6bbfc62bed717352"
Fixed #24432 -- Added docs for ManyToManyFields that reside in and refer
to the same model.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24432#comment:8>

Django

unread,
Mar 9, 2015, 8:46:38 PM3/9/15
to django-...@googlegroups.com
#24432: Documentation: M2M through attribute is underspecified
-------------------------------------+-------------------------------------
Reporter: marfire | Owner: fdh
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: master

Severity: Normal | Resolution: fixed
Keywords: afraid-to-commit | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"9853844ed3d3d25954205ce1b53962b57fef3d5e"]:
{{{
#!CommitTicketReference repository=""
revision="9853844ed3d3d25954205ce1b53962b57fef3d5e"
[1.8.x] Fixed #24432 -- Added docs for ManyToManyFields that reside in and


refer to the same model.

Backport of b9b8411129efe13642cef1fc6bbfc62bed717352 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24432#comment:9>

Django

unread,
Mar 9, 2015, 8:46:39 PM3/9/15
to django-...@googlegroups.com
#24432: Documentation: M2M through attribute is underspecified
-------------------------------------+-------------------------------------
Reporter: marfire | Owner: fdh
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: master

Severity: Normal | Resolution: fixed
Keywords: afraid-to-commit | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"7a08c966ac45a77e6a41fc1cfa1bdbca02dcb1ff"]:
{{{
#!CommitTicketReference repository=""
revision="7a08c966ac45a77e6a41fc1cfa1bdbca02dcb1ff"
[1.7.x] Fixed #24432 -- Added docs for ManyToManyFields that reside in and


refer to the same model.

Backport of b9b8411129efe13642cef1fc6bbfc62bed717352 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24432#comment:10>

Reply all
Reply to author
Forward
0 new messages