[Django] #18481: IOErrors from FILES are not wrapped with UnreadablePostError
Django
-------------------------------+--------------------
Reporter: KyleMac | Owner: nobody
Type: Uncategorized | Status: new
Component: HTTP handling | Version: 1.4
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------
Ticket #17277 wrapped IOErrors when reading the POST body with the custom
exception UnreadablePostError in order to make them easily identifiable
and thus easily ignored. However the same is not done when reading FILES
fails and a raw IOError is still raised.
Outside of AJAX it's failed file uploads that raise the most IOErrors and
so UnreadablePostError is not currently very useful.
--
Ticket URL: <https://code.djangoproject.com/ticket/18481>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Type: Uncategorized | Status: new
Component: HTTP handling | Version: 1.4
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by aaugustin):
* needs_better_patch: => 0
* needs_docs: => 0
* needs_tests: => 0
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/18481#comment:1>
Django
Reporter: KyleMac | Owner: nobody
Type: Uncategorized | Status: new
Component: HTTP handling | Version: 1.4
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by edevil):
* cc: andre.cruz@… (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/18481#comment:2>
Django
Reporter: KyleMac | Owner: nobody
Type: Uncategorized | Status: new
Component: HTTP handling | Version: 1.4
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by edevil):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/18481#comment:3>
Django
Reporter: KyleMac | Owner: nobody
Type: Uncategorized | Status: new
Component: HTTP handling | Version: 1.4
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by hirokiky):
* cc: hirokiky@… (added)
Comment:
I uploaded a patch about testing for this bug.
The testing was successful.
I applied the edevil's patch and run the testing with Python 2.7.1 and
3.3.
--
Ticket URL: <https://code.djangoproject.com/ticket/18481#comment:4>
Django
Reporter: KyleMac | Owner: nobody
Type: Uncategorized | Status: new
Component: HTTP handling | Version: 1.4
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by edevil):
I added a new patch that re-raises the exception in the standard format
seen on the rest of the codebase.
--
Ticket URL: <https://code.djangoproject.com/ticket/18481#comment:5>
Django
Reporter: KyleMac | Owner: nobody
Type: Bug | Status: new
Component: HTTP handling | Version: 1.4
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by anonymous):
What's missing?
--
Ticket URL: <https://code.djangoproject.com/ticket/18481#comment:7>
Django
Reporter: KyleMac | Owner: nobody
Type: Bug | Status: new
Component: HTTP handling | Version: 1.4
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by derega):
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/18481#comment:8>
Django
Reporter: KyleMac | Owner: nobody
Type: Bug | Status: new
Component: HTTP handling | Version: 1.4
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by anonymous):
Threre is also a patch for tests already attached.
--
Ticket URL: <https://code.djangoproject.com/ticket/18481#comment:9>
Django
Reporter: KyleMac | Owner: nobody
Type: Bug | Status: new
Component: HTTP handling | Version: 1.4
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by timo):
I believe this pull request is the same as the second patch, however, it
doesn't have any tests (django/http/request.py is the only modified file).
https://github.com/django/django/pull/675
--
Ticket URL: <https://code.djangoproject.com/ticket/18481#comment:10>
Django
Reporter: KyleMac | Owner: nobody
Type: Bug | Status: closed
Component: HTTP handling | Version: 1.4
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz <claude@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"de66b56790598f2ff97b8df859356d755ce64e20"]:
{{{
#!CommitTicketReference repository=""
revision="de66b56790598f2ff97b8df859356d755ce64e20"
Fixed #18481 -- Wrapped request.FILES read error in UnreadablePostError
Thanks KyleMac for the report, André Cruz for the initial patch and
Hiroki Kiyohara for the tests.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/18481#comment:11>