[Django] #27393: Admin: input boxes on password reset forms are not aligned

52 views
Skip to first unread message

Django

unread,
Oct 27, 2016, 2:23:23 AM10/27/16
to django-...@googlegroups.com
#27393: Admin: input boxes on password reset forms are not aligned
--------------------------------+--------------------
Reporter: Michiel Beijen | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 1
--------------------------------+--------------------
The password reset and enter new password form input boxes are not
aligned.

[[Image(https://download.x14.nl/django-password-reset.png)]]

[[Image(https://download.x14.nl/django-enter-new-password.png)]]

This contrary to the password change form:

[[Image(https://download.x14.nl/django-password-change.png)]]

--
Ticket URL: <https://code.djangoproject.com/ticket/27393>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 27, 2016, 2:30:51 AM10/27/16
to django-...@googlegroups.com
#27393: Admin: input boxes on password reset forms are not aligned
----------------------------+----------------------------

Reporter: Michiel Beijen | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Easy pickings: 0
UI/UX: 1 |
----------------------------+----------------------------
Changes (by Michiel Beijen):

* Attachment "django-password-reset.png" added.

Existing password reset screen

Django

unread,
Oct 27, 2016, 2:32:07 AM10/27/16
to django-...@googlegroups.com
#27393: Admin: input boxes on password reset forms are not aligned
----------------------------+----------------------------

Reporter: Michiel Beijen | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Easy pickings: 0
UI/UX: 1 |
----------------------------+----------------------------
Changes (by Michiel Beijen):

* Attachment "django-enter-new-password.png" added.

Existing enter new password dialog

Django

unread,
Oct 27, 2016, 2:33:23 AM10/27/16
to django-...@googlegroups.com
#27393: Admin: input boxes on password reset forms are not aligned
----------------------------+----------------------------

Reporter: Michiel Beijen | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Easy pickings: 0
UI/UX: 1 |
----------------------------+----------------------------
Changes (by Michiel Beijen):

* Attachment "django-password-change.png" added.

Existing password change screen (looks good)

Django

unread,
Oct 27, 2016, 2:35:06 AM10/27/16
to django-...@googlegroups.com
#27393: Admin: input boxes on password reset forms are not aligned
----------------------------+----------------------------

Reporter: Michiel Beijen | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Easy pickings: 0
UI/UX: 1 |
----------------------------+----------------------------
Changes (by Michiel Beijen):

* Attachment "django-password-reset-new.png" added.

New password reset screen

Django

unread,
Oct 27, 2016, 2:46:02 AM10/27/16
to django-...@googlegroups.com
#27393: Admin: input boxes on password reset forms are not aligned
----------------------------+----------------------------

Reporter: Michiel Beijen | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Easy pickings: 0
UI/UX: 1 |
----------------------------+----------------------------
Changes (by Michiel Beijen):

* Attachment "django-enter-new-password-new.png" added.

New enter new password dialog

Django

unread,
Oct 27, 2016, 2:47:18 AM10/27/16
to django-...@googlegroups.com
#27393: Admin: input boxes on password reset forms are not aligned
--------------------------------+--------------------------------------

Reporter: Michiel Beijen | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
--------------------------------+--------------------------------------
Changes (by Michiel Beijen):

* cc: mb@… (added)
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0


Old description:

> The password reset and enter new password form input boxes are not
> aligned.
>
> [[Image(https://download.x14.nl/django-password-reset.png)]]
>
> [[Image(https://download.x14.nl/django-enter-new-password.png)]]
>
> This contrary to the password change form:
>
> [[Image(https://download.x14.nl/django-password-change.png)]]

New description:

The password reset and enter new password form input boxes are not
aligned.

This contrary to the password change form, see attachments.

I created a PR for this, with screen shots of before and after:
https://github.com/django/django/pull/7438

--

--
Ticket URL: <https://code.djangoproject.com/ticket/27393#comment:1>

Django

unread,
Oct 27, 2016, 1:27:46 PM10/27/16
to django-...@googlegroups.com
#27393: Admin: input boxes on password reset forms are not aligned
--------------------------------------+------------------------------------

Reporter: Michiel Beijen | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
--------------------------------------+------------------------------------
Changes (by Tim Graham):

* type: Bug => Cleanup/optimization
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/27393#comment:2>

Django

unread,
Nov 5, 2016, 7:01:10 AM11/5/16
to django-...@googlegroups.com
#27393: Admin: input boxes on password reset forms are not aligned
-------------------------------------+-------------------------------------

Reporter: Michiel Beijen | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Matthias Kestenholz):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/27393#comment:3>

Django

unread,
Nov 15, 2016, 11:22:04 AM11/15/16
to django-...@googlegroups.com
#27393: Admin: input boxes on password reset forms are not aligned
-------------------------------------+-------------------------------------

Reporter: Michiel Beijen | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"364293529ba1106cd4605787a7f3d1b323b2a820" 36429352]:
{{{
#!CommitTicketReference repository=""
revision="364293529ba1106cd4605787a7f3d1b323b2a820"
Fixed #27393 -- Aligned input boxes in admin password reset forms.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27393#comment:4>

Reply all
Reply to author
Forward
0 new messages