[Django] #26391: JSONField empty_values
Django
-------------------------------------+-------------------------------------
Reporter: sim1234 | Owner:
Type: | Status: new
Cleanup/optimization |
Component: contrib.postgres | Version: 1.9
Severity: Normal | Keywords: JSON JSONField postgres
| forms
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
When validating required JSONField with values '{}', '[]' or '""' a
ValidationError is raised.
In case of JSON, only None (null) should be considered an empty value.
--
Ticket URL: <https://code.djangoproject.com/ticket/26391>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: sim1234 | Owner:
Type: | Status: new
Cleanup/optimization |
Component: contrib.postgres | Version: 1.9
Keywords: JSON JSONField | Triage Stage:
postgres forms | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
Pull request: [https://github.com/django/django/pull/6320]
--
Ticket URL: <https://code.djangoproject.com/ticket/26391#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: sim1234 | Owner:
Type: | Status: new
Cleanup/optimization |
Component: contrib.postgres | Version: 1.9
Keywords: JSON JSONField | Triage Stage:
postgres forms | Unreviewed
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
* needs_tests: 0 => 1
Comment:
Regression tests are needed to demonstrate what this fixes. Also the
current patch causes a regression of
`postgres_tests.test_json.TestFormField.test_valid_empty`.
--
Ticket URL: <https://code.djangoproject.com/ticket/26391#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: sim1234 | Owner:
Cleanup/optimization |
Component: contrib.postgres | Version: 1.9
Keywords: JSON JSONField | Triage Stage:
postgres forms | Unreviewed
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => needsinfo
--
Ticket URL: <https://code.djangoproject.com/ticket/26391#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: sim1234 | Owner: (none)
Type: | Status: closed
Cleanup/optimization |
Component: contrib.postgres | Version: 1.9
Keywords: JSON JSONField | Triage Stage:
postgres forms | Unreviewed
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Matt Hegarty):
Can we re-open this as a bug? The default behaviour of JSONFields in the
admin console is to fail when you try to save (see attached).
Also raised on [https://stackoverflow.com/a/56271722/39296 SO]
The workaround is:
{{{
# forms.py
class ValidEmptyJSONField(forms.JSONField):
empty_values = [None, "", [], ()]
from django.db.models import JSONField
class ValidEmptyJSONField(JSONField):
"""
Overridden to permit valid empty JSON.
"""
empty_values = [None, "", [], ()]
def formfield(self, **kwargs):
from app import forms
return super().formfield(**{"form_class":
forms.ValidEmptyJSONField, **kwargs})
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26391#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: sim1234 | Owner: (none)
Type: | Status: closed
Cleanup/optimization |
Component: contrib.postgres | Version: 1.9
Keywords: JSON JSONField | Triage Stage:
postgres forms | Unreviewed
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* Attachment "invalid_empty_json_field.png" added.
Django
-------------------------------------+-------------------------------------
Reporter: sim1234 | Owner: (none)
Type: | Status: closed
Cleanup/optimization |
Component: contrib.postgres | Version: 1.9
Keywords: JSON JSONField | Triage Stage:
postgres forms | Unreviewed
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham):
That's discussed in #27697.
--
Ticket URL: <https://code.djangoproject.com/ticket/26391#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: sim1234 | Owner: (none)
Type: | Status: closed
Cleanup/optimization |
Component: contrib.postgres | Version: 1.9
Keywords: JSON JSONField | Triage Stage:
postgres forms | Unreviewed
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Matt Hegarty):
ok - thanks Tim
--
Ticket URL: <https://code.djangoproject.com/ticket/26391#comment:6>