[Django] #13163: Display link to change-form on inlines where model is registered in admin site
Django
site
----------------------------------+-----------------------------------------
Reporter: DrMeers | Owner: nobody
Status: new | Milestone: 1.2
Component: django.contrib.admin | Version: SVN
Keywords: inline link | Stage: Unreviewed
Has_patch: 1 |
----------------------------------+-----------------------------------------
If an inline object has a {{{get_absolute_url}}} method, a 'View on site'
link is displayed.
Here I propose that if an inline object is registered in the same admin
site, an 'Edit' link is displayed in a similar fashion.
Why?
* The inline may only display a subset of fields, so the user may wish to
go to the full change form
* 'Recursive inlines' can be accessed more easily -- e.g. {{{Household}}}
has {{{Person}}} inlines, and {{{Person}}} has {{{Phone}}} inlines, etc.
The attached patch shows a draft implementation.
Questions:
* Do we need to check if the user has change permissions on that model
before displaying the link? (in the unlikely event that the user has
permission to change a model which displays the inlines of a model which
they do not have change permissions for). Given that I cannot see a
straightforward way of checking for this without the addition of a
template tag/filter, and the rarity of such setups, I'd be happy to let
the user click the link and get a permission denied page.
* Do we need an {{{InlineModelAdmin}}} option for enabling/disabling this
link? E.g. {{{InlineModelAdmin.show_admin_link}}}. Or are we happy to have
it enabled globally?
* Is {{{[ Edit ]}}} a sufficiently understandable link label? Would "Edit
in Admin", or "Display full form" or something be more appropriate?
I think the reciprocal of this would also be very useful --
{{{ForeignKey}}} widgets could display an {{{[edit]}}} link beside the
"add new" (green +) link which links to the change form for the selected
parent object.
--
Ticket URL: <http://code.djangoproject.com/ticket/13163>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
site
Status: new | Milestone:
Resolution: | Keywords: inline link
Stage: Unreviewed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------
Changes (by kmtracey):
* needs_better_patch: => 0
* needs_docs: => 0
* needs_tests: => 0
* milestone: 1.2 =>
Comment:
This is a feature request and thus not appropriate for the 1.2 milestone
at this point.
--
Ticket URL: <http://code.djangoproject.com/ticket/13163#comment:1>
Django
site
Reporter: DrMeers | Owner: DrMeers
Status: assigned | Milestone:
Component: User Experience | Version: SVN
Resolution: | Keywords: inline link
Stage: Accepted | Has_patch: 1
Needs_better_patch: 0 |
Changes (by DrMeers):
* owner: => DrMeers
* status: new => assigned
--
Ticket URL: <http://code.djangoproject.com/ticket/13163#comment:3>
Django
site
Reporter: DrMeers | Owner: DrMeers
Resolution: | Keywords: inline link
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
--------------------------------------+-------------------------------------
Changes (by DrMeers):
--
Ticket URL: <http://code.djangoproject.com/ticket/13163#comment:4>
--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To post to this group, send email to django-...@googlegroups.com.
To unsubscribe from this group, send email to django-update...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/django-updates?hl=en.
Django
site
Reporter: DrMeers | Owner: DrMeers
Status: assigned | Milestone: 1.3
Component: User Experience | Version: SVN
Resolution: | Keywords: inline link
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
--------------------------------------+-------------------------------------
* cc: sr...@mahiti.org (added)
--
Ticket URL: <http://code.djangoproject.com/ticket/13163#comment:5>
Django
site
Status: assigned | Milestone: 1.3
Component: User Experience | Version: SVN
Resolution: | Keywords: inline link
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 |
-------------------------------------------+---------------------------
Changes (by EnTeQuAk):
* cc: cg@… (added)
--
Ticket URL: <http://code.djangoproject.com/ticket/13163#comment:6>
Django
site
Reporter: DrMeers | Owner: DrMeers
Type: New feature | Status: assigned
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
---------------------------------------+---------------------------------
Changes (by anonymous):
* easy: => 0
Comment:
With Django 1.3 does not work. Is there anything like that under 1.3 ?
--
Ticket URL: <http://code.djangoproject.com/ticket/13163#comment:9>
Django
site
---------------------------------------+---------------------------------
Reporter: DrMeers | Owner: DrMeers
Type: New feature | Status: assigned
Milestone: 1.3 | Component: User Experience
Version: SVN | Severity: Normal
Resolution: | Keywords: inline link
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
---------------------------------------+---------------------------------
Changes (by patchhammer):
* needs_better_patch: 0 => 1
Comment:
combined_13165_13165.diff fails to apply cleanly on to trunk
--
Ticket URL: <http://code.djangoproject.com/ticket/13163#comment:10>
Django <https://code.djangoproject.com/>
Django
site
---------------------------------------+-------------------------------
Type: New feature | Status: assigned
Resolution: | Keywords: inline link
Triage Stage: Accepted | Has patch: 1
---------------------------------------+-------------------------------
Changes (by dperetti):
* needs_tests: 0 => 1
Comment:
Hey guys, I've just added above my own implementation of this feature.
Very simple, just 3 lines of code but does the job.
(This patch does it only in tabular.html).
{{{
class BooksInline(admin.TabularInline):
model = Book
show_edit_link = True
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/13163#comment:13>
Django
site
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: inline link | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
Comment (by anonymous):
any chance this will make it into 1.4 ?
--
Ticket URL: <https://code.djangoproject.com/ticket/13163#comment:15>
Django
site
-------------------------------+------------------------------------
Reporter: DrMeers | Owner: DrMeers
Type: New feature | Status: assigned
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: inline link | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Comment (by anonymous):
still waiting for this to become a feature.
--
Ticket URL: <https://code.djangoproject.com/ticket/13163#comment:16>
Django
site
-------------------------------+------------------------------------
Reporter: DrMeers | Owner: DrMeers
Type: New feature | Status: assigned
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: inline link | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
* cc: glicerinu@… (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/13163#comment:17>
Django
site
-------------------------------+------------------------------------
Reporter: DrMeers | Owner: DrMeers
Type: New feature | Status: assigned
Keywords: inline link | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Comment (by charettes):
I packaged a simple app providing admin mixins to add a the edition and
deletion links on all amin FK widgets, including those in inlines. You can
find the project on [https://github.com/charettes/django-admin-enhancer
github] and on [http://pypi.python.org/pypi/django-admin-enhancer/0.1.0
pypi].
--
Ticket URL: <https://code.djangoproject.com/ticket/13163#comment:18>
Django
site
-------------------------------+------------------------------------
Reporter: DrMeers | Owner: DrMeers
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: inline link | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Comment (by blueyed):
@smcoll:
It looks like there is a wrong `if` in your patch: `{% if
inline_admin_form.original %}`. It should check for the new
`show_edit_link` option probably.
I assume that it won't work for many2many inlines, where you have `model =
Foo.bars.through`?
--
Ticket URL: <https://code.djangoproject.com/ticket/13163#comment:19>
Django
site
-------------------------------+------------------------------------
Reporter: DrMeers | Owner: DrMeers
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: inline link | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
* needs_docs: 0 => 1
* needs_tests: 1 => 0
* needs_better_patch: 1 => 0
Comment:
PR here: https://github.com/django/django/pull/2957.
I added a method `AdminSite.is_registered()` which takes a `Model` class
or lowercased model name. This is needed for checking if the
`InlineModelAdmin`'s model is also registered as a `ModelAdmin` on the
site. There is precedence for this sort of check with registries -- the
app registry has `apps.is_installed()`, and it seems to be a reasonable
method to have on the `AdminSite`.
Renamed the `show_edit_link` to `show_change_link` for consistency across
the admin. The link will only be displayed if `show_change_link = True` on
the inline, the model itself is also registered, and there is an inline
object to change.
--
Ticket URL: <https://code.djangoproject.com/ticket/13163#comment:20>
Django
site
-------------------------------+------------------------------------
Reporter: DrMeers | Owner: DrMeers
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: inline link | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by slurms):
* needs_docs: 1 => 0
Comment:
Added docs, updated PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/13163#comment:21>
Django
site
-------------------------------+------------------------------------
Reporter: DrMeers | Owner: DrMeers
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: inline link | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"9d9f0acd7e245c9f9c30727a003666618754c924"]:
{{{
#!CommitTicketReference repository=""
revision="9d9f0acd7e245c9f9c30727a003666618754c924"
Fixed #13163 -- Added ability to show change links on inline objects in
admin.
Thanks DrMeers for the suggestion.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/13163#comment:22>