--
Ticket URL: <https://code.djangoproject.com/ticket/28184>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
* needs_better_patch: 0 => 1
* easy: 1 => 0
* stage: Unreviewed => Accepted
Comment:
Tentatively accepting. This idea also came up in #24648. The PR has test
failures and documentation changes are also required. See the
PatchReviewChecklist.
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:1>
* needs_better_patch: 1 => 0
Comment:
Improved patch, passes all tests now.
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:2>
* needs_better_patch: 0 => 1
* needs_docs: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:3>
Comment (by Carlton Gibson):
Left some comments on PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:4>
Comment (by miigotu):
Replying to [comment:4 Carlton Gibson]:
> Left some comments on PR.
PR Updated, please review
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:5>
* needs_better_patch: 1 => 0
* needs_docs: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:6>
* version: 1.11 => master
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:7>
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:8>
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:9>
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:10>
Comment (by Carlton Gibson <carlton@…>):
In [changeset:"94b32a20ef798768029651f0e8fcc07731a62a64" 94b32a2]:
{{{
#!CommitTicketReference repository=""
revision="94b32a20ef798768029651f0e8fcc07731a62a64"
Refs #28184 -- Added test for FileField storage default.
Co-authored-by: miigotu <mii...@gmail.com>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:12>
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"210657b791fec359a9109b69e566018253edfad0" 210657b7]:
{{{
#!CommitTicketReference repository=""
revision="210657b791fec359a9109b69e566018253edfad0"
Fixed #28184 -- Allowed using a callable for FileField and ImageField
storage.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28184#comment:11>