[Django] #22661: MakeMigrationTests placed inside MigrateTests class
Django
--------------------------------------+------------------------
Reporter: whoshuu | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Migrations | Version: 1.7-beta-2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------
In `tests/migrations/test_commands.py`, the tests
[https://github.com/django/django/blob/master/tests/migrations/test_commands.py#L88-L109
here] should be moved into the `MakeMigrationsTests` class because they
test the `makemigration` command, not the `migrate` command.
--
Ticket URL: <https://code.djangoproject.com/ticket/22661>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: whoshuu | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version:
Component: Migrations | 1.7-beta-2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by timo):
* needs_better_patch: => 0
* stage: Unreviewed => Accepted
* needs_tests: => 0
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/22661#comment:1>
Django
Reporter: whoshuu | Owner: whoshuu
Type: | Status: assigned
Cleanup/optimization | Version:
Component: Migrations | 1.7-beta-2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by whoshuu):
* status: new => assigned
* owner: nobody => whoshuu
--
Ticket URL: <https://code.djangoproject.com/ticket/22661#comment:2>
Django
Reporter: whoshuu | Owner: whoshuu
Type: | Status: assigned
Cleanup/optimization | Version:
Component: Migrations | 1.7-beta-2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by whoshuu):
Opened up a pull request for this
[https://github.com/django/django/pull/2688 here].
--
Ticket URL: <https://code.djangoproject.com/ticket/22661#comment:3>
Django
Reporter: whoshuu | Owner: whoshuu
Type: | Status: assigned
Cleanup/optimization | Version:
Component: Migrations | 1.7-beta-2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by whoshuu):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/22661#comment:4>
Django
Reporter: whoshuu | Owner: whoshuu
Cleanup/optimization | Version:
Component: Migrations | 1.7-beta-2
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Huu Nguyen <huu@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"44304cf04e46cf7fa974571efd24716e03e05f94"]:
{{{
#!CommitTicketReference repository=""
revision="44304cf04e46cf7fa974571efd24716e03e05f94"
Fixed #22661 -- Move makemigrations tests to the proper class
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22661#comment:5>
Django
Reporter: whoshuu | Owner: whoshuu
Type: | Status: closed
Cleanup/optimization | Version:
Component: Migrations | 1.7-beta-2
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Claude Paroz <claude@…>):
In [changeset:"07b6404d2245519fd88c2d51b4455ed099d3a1f0"]:
{{{
#!CommitTicketReference repository=""
revision="07b6404d2245519fd88c2d51b4455ed099d3a1f0"
Merge pull request #2688 from whoshuu/22661
Fixed #22661 -- Move makemigrations tests to the proper class
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22661#comment:6>
Django
Reporter: whoshuu | Owner: whoshuu
Type: | Status: closed
Cleanup/optimization | Version:
Component: Migrations | 1.7-beta-2
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"f7270dcd9d655f037604cf6044306582875dfbf4"]:
{{{
#!CommitTicketReference repository=""
revision="f7270dcd9d655f037604cf6044306582875dfbf4"
[1.7.x] Fixed #22661 -- Move makemigrations tests to the proper class
Backport of 44304cf04e from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22661#comment:7>