[Django] #23975: No pre migrate signal emmited if all installed apps have migrations
Django
----------------------------+---------------------
Reporter: kmmbvnr | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: 1.7
Severity: Normal | Keywords: signals
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
----------------------------+---------------------
The sync_db() function is the only place where pre_migrate signal is
emitted. And it's called only in case if there is apps without migrations.
https://github.com/django/django/blob/bac7664f274be834a09e037331889959f04a75e7/django/core/management/commands/migrate.py#L156
https://github.com/django/django/blob/bac7664f274be834a09e037331889959f04a75e7/django/core/management/commands/migrate.py#L252
If all installed applications have migrations, no pre_migrate signal
happens.
--
Ticket URL: <https://code.djangoproject.com/ticket/23975>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: kmmbvnr | Owner: timgraham
Type: Bug | Status: assigned
Component: Migrations | Version: 1.7
Severity: Release blocker | Resolution:
Keywords: signals | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* status: new => assigned
* severity: Normal => Release blocker
* needs_better_patch: => 0
* needs_tests: => 0
* owner: nobody => timgraham
* needs_docs: => 0
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/23975#comment:1>
Django
Reporter: kmmbvnr | Owner: timgraham
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
Keywords: signals | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/3711 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/23975#comment:2>
Django
---------------------------------+-------------------------------------
Reporter: kmmbvnr | Owner: timgraham
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
Keywords: signals | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
--
Ticket URL: <https://code.djangoproject.com/ticket/23975#comment:3>
Django
---------------------------------+-------------------------------------
Reporter: kmmbvnr | Owner: timgraham
Component: Migrations | Version: 1.7
Severity: Release blocker | Resolution: fixed
Keywords: signals | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"d2ff8a7241b621b8013c7ec1631e95ae4445f76d"]:
{{{
#!CommitTicketReference repository=""
revision="d2ff8a7241b621b8013c7ec1631e95ae4445f76d"
Fixed #23975 -- Restored pre_migrate signal if all apps have migrations.
Thanks kmmbvnr for the report.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23975#comment:4>
Django
---------------------------------+-------------------------------------
Reporter: kmmbvnr | Owner: timgraham
Type: Bug | Status: closed
Severity: Release blocker | Resolution: fixed
Keywords: signals | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"c085bea6c34979b9acc3108afd018cb391557002"]:
{{{
#!CommitTicketReference repository=""
revision="c085bea6c34979b9acc3108afd018cb391557002"
[1.7.x] Fixed #23975 -- Restored pre_migrate signal if all apps have
migrations.
Thanks kmmbvnr for the report.
Backport of d2ff8a7241b621b8013c7ec1631e95ae4445f76d from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23975#comment:5>