[Django] #27701: Document that runserver bypasses middleware for static files

34 views
Skip to first unread message

Django

unread,
Jan 7, 2017, 11:57:09 PM1/7/17
to django-...@googlegroups.com
#27701: Document that runserver bypasses middleware for static files
-------------------------------------+-------------------------------------
Reporter: Kevin | Owner: nobody
Christopher Henry |
Type: | Status: new
Cleanup/optimization |
Component: | Version: master
Documentation |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
It seems that when `runserver` (with `django.contrib.staticfiles`) serves
static files the request completely bypasses middleware. This caught me
off guard, and as far as I can tell isn't documented. It probably should
be.

--
Ticket URL: <https://code.djangoproject.com/ticket/27701>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 9, 2017, 6:58:50 AM1/9/17
to django-...@googlegroups.com
#27701: Document that runserver bypasses middleware for static files
-------------------------------------+-------------------------------------
Reporter: Kevin Christopher | Owner: nobody

Henry |
Type: | Status: new
Cleanup/optimization |
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/27701#comment:1>

Django

unread,
Aug 18, 2017, 5:48:54 PM8/18/17
to django-...@googlegroups.com
#27701: Document that runserver bypasses middleware for static files
-------------------------------------+-------------------------------------
Reporter: Kevin Christopher | Owner: Jkrzy
Henry |
Type: | Status: assigned

Cleanup/optimization |
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jkrzy):

* owner: nobody => Jkrzy
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/27701#comment:2>

Django

unread,
Aug 18, 2017, 6:05:25 PM8/18/17
to django-...@googlegroups.com
#27701: Document that runserver bypasses middleware for static files
-------------------------------------+-------------------------------------
Reporter: Kevin Christopher | Owner: Jkrzy
Henry |
Type: | Status: assigned
Cleanup/optimization |
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jkrzy):

* has_patch: 0 => 1


Comment:

Added note snippet reflecting this behavior to staticfiles runserver doc
section.

https://github.com/django/django/pull/8942

--
Ticket URL: <https://code.djangoproject.com/ticket/27701#comment:3>

Django

unread,
Aug 30, 2017, 3:42:51 PM8/30/17
to django-...@googlegroups.com
#27701: Document that runserver bypasses middleware for static files
-------------------------------------+-------------------------------------
Reporter: Kevin Christopher | Owner: Joe
Henry | Krzystan

Type: | Status: assigned
Cleanup/optimization |
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Martin):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/27701#comment:4>

Django

unread,
Aug 30, 2017, 9:31:23 PM8/30/17
to django-...@googlegroups.com
#27701: Document that runserver bypasses middleware for static files
-------------------------------------+-------------------------------------
Reporter: Kevin Christopher | Owner: Joe
Henry | Krzystan
Type: | Status: closed

Cleanup/optimization |
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"20a761697fd28c08ab82dec777b4056a5bfaf6a2" 20a76169]:
{{{
#!CommitTicketReference repository=""
revision="20a761697fd28c08ab82dec777b4056a5bfaf6a2"
Fixed #27701 -- Doc'd staticfiles runserver bypasses middleware when
serving static files.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27701#comment:5>

Django

unread,
Aug 30, 2017, 9:31:33 PM8/30/17
to django-...@googlegroups.com
#27701: Document that runserver bypasses middleware for static files
-------------------------------------+-------------------------------------
Reporter: Kevin Christopher | Owner: Joe
Henry | Krzystan
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"046b8c80ce76ed1d410910aa92f67c405b8a15ba" 046b8c8]:
{{{
#!CommitTicketReference repository=""
revision="046b8c80ce76ed1d410910aa92f67c405b8a15ba"
[1.11.x] Fixed #27701 -- Doc'd staticfiles runserver bypasses middleware
when serving static files.

Backport of 20a761697fd28c08ab82dec777b4056a5bfaf6a2 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27701#comment:6>

Reply all
Reply to author
Forward
0 new messages