[Django] #30102: Optimize the `page_not_found` after #30070
Django
------------------------------------------------+------------------------
Reporter: Illia Volochii | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
There is no need to use the template system
[https://github.com/django/django/blob/573f44d62fe1e87e2c20a74eba5e20ca9ff0ed85/django/views/defaults.py#L55
here].
The content has not got variables and can be just a byte string.
--
Ticket URL: <https://code.djangoproject.com/ticket/30102>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: Illia Volochii | Owner: nobody
Cleanup/optimization |
Component: Core (Other) | Version: master
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--
Ticket URL: <https://code.djangoproject.com/ticket/30102#comment:1>
Django
-------------------------------------+-------------------------------------
Cleanup/optimization |
Component: Core (Other) | Version: master
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson):
* status: new => closed
* resolution: => wontfix
Comment:
As per [https://github.com/django/django/pull/10841 discussion on the
original PR], there are test cases relying on the template context being
available on the response. Working around this ~~probably~~ isn't worth
the effort. [https://github.com/django/django/pull/10855 Follow-up PR]
adds a comment explaining the usage, as per Tim's suggestion.
--
Ticket URL: <https://code.djangoproject.com/ticket/30102#comment:2>
Django
-------------------------------------+-------------------------------------
Cleanup/optimization |
Component: Core (Other) | Version: master
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by GitHub <noreply@…>):
In [changeset:"876dc306cd508a041ccc62cf87397514fce4c9f3" 876dc30]:
{{{
#!CommitTicketReference repository=""
revision="876dc306cd508a041ccc62cf87397514fce4c9f3"
Refs #30102 -- Added comment on use of Template without placeholders in
page_not_found() view.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30102#comment:3>