[Django] #31034: Add a navigation sidebar to the admin
Django
-----------------------------------------+------------------------
Reporter: Tom Carrick | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
Title says it all, really. The idea is to add an optional (probably
enabled by default?) sidebar for navigation, doing roughly what the
current homepage does. For now, it'll be a simple implementation only for
large screens, and hopefully it can be iterated on in the future.
I opened a discussion here, only got one response but it was positive and
I think it's not too controversial if it's behind a flag:
https://groups.google.com/forum/#!topic/django-developers/PAZw8chsp2g
--
Ticket URL: <https://code.djangoproject.com/ticket/31034>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Tom Carrick | Owner: Tom Carrick
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tom Carrick):
* status: new => assigned
* owner: nobody => Tom Carrick
--
Ticket URL: <https://code.djangoproject.com/ticket/31034#comment:1>
Django
Reporter: Tom Carrick | Owner: Tom Carrick
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson):
* stage: Unreviewed => Accepted
Comment:
OK, thanks. Accepting on the basis of the discussion. 👍
--
Ticket URL: <https://code.djangoproject.com/ticket/31034#comment:2>
Django
Reporter: Tom Carrick | Owner: Tom Carrick
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+---------------------------------------
Changes (by Tom Carrick):
* needs_docs: 0 => 1
* has_patch: 0 => 1
* ui_ux: 0 => 1
* needs_tests: 0 => 1
Comment:
[https://github.com/django/django/pull/#### PR]
Needs tests and docs but wanted to get some feedback first.
--
Ticket URL: <https://code.djangoproject.com/ticket/31034#comment:3>
Django
Reporter: Tom Carrick | Owner: Tom Carrick
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
-------------------------------+---------------------------------------
Changes (by Tom Carrick):
* needs_tests: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/31034#comment:4>
Django
Reporter: Tom Carrick | Owner: Tom Carrick
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------+---------------------------------------
Changes (by Tom Carrick):
* needs_docs: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/31034#comment:5>
Django
Reporter: Tom Carrick | Owner: Tom Carrick
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------+---------------------------------------
Comment (by Tim Graham):
To control its display, I'd think an admin site attribute would be
preferred to a setting. Generally, settings are only added as a last
resort.
--
Ticket URL: <https://code.djangoproject.com/ticket/31034#comment:6>
Django
Reporter: Tom Carrick | Owner: Tom Carrick
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+---------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/31034#comment:7>
Django
Reporter: Tom Carrick | Owner: Tom Carrick
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------+---------------------------------------
Changes (by Tom Carrick):
* needs_better_patch: 1 => 0
Comment:
Thanks. I've fixed that, now I'm just having a problem figuring out the
test failure.
--
Ticket URL: <https://code.djangoproject.com/ticket/31034#comment:8>
Django
Reporter: Tom Carrick | Owner: Tom Carrick
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+---------------------------------------
* needs_better_patch: 0 => 1
Comment:
I posted to the mailing list thread to see if we can find a Design/UX/CSS
expert to input on the PR.
If not, I think we should proceed. It's a improvement, and we can iterate
on it over time.
There's one CSS issue that we should resolve (at least) commented on the
PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/31034#comment:9>
Django
Reporter: Tom Carrick | Owner: Tom Carrick
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------+---------------------------------------
Changes (by Tom Carrick):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/31034#comment:10>
Django
Reporter: Tom Carrick | Owner: Tom Carrick
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------+---------------------------------------
Changes (by Tom Carrick):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/31034#comment:11>
Django
Reporter: Tom Carrick | Owner: Tom Carrick
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------+---------------------------------------
Changes (by Tom Carrick):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/31034#comment:12>
Django
Reporter: Tom Carrick | Owner: Tom
| Carrick
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/31034#comment:13>
Django
Reporter: Tom Carrick | Owner: Tom
| Carrick
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"d24ba1be7a53a113d19e2860c03aff9922efec24" d24ba1be]:
{{{
#!CommitTicketReference repository=""
revision="d24ba1be7a53a113d19e2860c03aff9922efec24"
Fixed #31034 -- Added a navigation sidebar to the admin.
Co-authored-by: elky <el...@users.noreply.github.com>
Co-authored-by: Goetz <goetz....@gmail.com>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31034#comment:14>
Django
Reporter: Tom Carrick | Owner: Tom
| Carrick
Type: New feature | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"e341bed606d8ab2864838795276692cf86b08687" e341bed6]:
{{{
#!CommitTicketReference repository=""
revision="e341bed606d8ab2864838795276692cf86b08687"
Refs #31034 -- Documented admin requires
django.template.context_processors.request.
Required since d24ba1be7a53a113d19e2860c03aff9922efec24.
Co-authored-by: Carlton Gibson <carlton...@noumenal.es>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31034#comment:15>
Django
Reporter: Tom Carrick | Owner: Tom
| Carrick
Type: New feature | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"c9a9d042e5182cfb6c9aceaf292e5e3727f624dd" c9a9d042]:
{{{
#!CommitTicketReference repository=""
revision="c9a9d042e5182cfb6c9aceaf292e5e3727f624dd"
[3.1.x] Refs #31034 -- Documented admin requires
django.template.context_processors.request.
Required since d24ba1be7a53a113d19e2860c03aff9922efec24.
Co-authored-by: Carlton Gibson <carlton...@noumenal.es>
Backport of e341bed606d8ab2864838795276692cf86b08687 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31034#comment:16>
Django
Reporter: Tom Carrick | Owner: Tom
| Carrick
Type: New feature | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"e46f700e39cef3856f34b56dc5d563d3e27648ac" e46f700]:
{{{
#!CommitTicketReference repository=""
revision="e46f700e39cef3856f34b56dc5d563d3e27648ac"
Refs #31034 -- Used === in nav_sidebar.js admin JS to avoid possible
coercion issues.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31034#comment:17>
Django
Reporter: Tom Carrick | Owner: Tom
| Carrick
Type: New feature | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"16716551bda6b088fcd41d7d12a782b758e8dcb7" 16716551]:
{{{
#!CommitTicketReference repository=""
revision="16716551bda6b088fcd41d7d12a782b758e8dcb7"
[3.1.x] Refs #31034 -- Used === in nav_sidebar.js admin JS to avoid
possible coercion issues.
Backport of e46f700e39cef3856f34b56dc5d563d3e27648ac from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31034#comment:18>
Django
Reporter: Tom Carrick | Owner: Tom
| Carrick
Type: New feature | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"780473d75625d014cbe9b0acdea40b7a5970d5d8" 780473d]:
{{{
#!CommitTicketReference repository=""
revision="780473d75625d014cbe9b0acdea40b7a5970d5d8"
Refs #31034 -- Improved accessibility of admin navigation sidebar.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31034#comment:19>
Django
Reporter: Tom Carrick | Owner: Tom
| Carrick
Type: New feature | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"dc3234be48d17def4e951d678c0ec39c5ff94830" dc3234be]:
{{{
#!CommitTicketReference repository=""
revision="dc3234be48d17def4e951d678c0ec39c5ff94830"
[3.1.x] Refs #31034 -- Improved accessibility of admin navigation sidebar.
Backport of 780473d75625d014cbe9b0acdea40b7a5970d5d8 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31034#comment:20>