[Django] #20134: UserManager documentation doesn't mention that it depends on date_joined

15 views
Skip to first unread message

Django

unread,
Mar 25, 2013, 2:58:50 PM3/25/13
to django-...@googlegroups.com
#20134: UserManager documentation doesn't mention that it depends on date_joined
--------------------------------------+--------------------
Reporter: semenov | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.5
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
The documentation at
https://docs.djangoproject.com/en/dev/topics/auth/customizing/ says:

If your User model defines username and email fields the same as Django’s
default User, you can just install Django’s UserManager.

This is not true in the sense that these are not the only required fields
for Django's UserManager to be a drop-in replacement. One has also to
define `MyUser.date_joined`, otherwise `UserManager.create_user(..)` would
fail to create a user.

The documentation should be updated to reflect that date_joined field is
also required to use Django's UserManager.

--
Ticket URL: <https://code.djangoproject.com/ticket/20134>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 4, 2013, 1:32:17 AM4/4/13
to django-...@googlegroups.com
#20134: UserManager documentation doesn't mention that it depends on date_joined
--------------------------------------+------------------------------------

Reporter: semenov | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.5
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by pegler):

* cc: pegler@… (added)
* needs_better_patch: => 0
* needs_docs: => 0
* needs_tests: => 0
* stage: Unreviewed => Accepted


Comment:

Agreed, the docs should be modified to indicate that `UserManager`
requires `is_staff`, `is_active`, `is_superuser`, `last_login`, and
`date_joined` fields to be used.

Best,
Matt

--
Ticket URL: <https://code.djangoproject.com/ticket/20134#comment:1>

Django

unread,
Jul 4, 2013, 10:20:01 AM7/4/13
to django-...@googlegroups.com
#20134: UserManager documentation doesn't mention that it depends on date_joined
--------------------------------------+------------------------------------
Reporter: semenov | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.5
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"da5069f68f9ec0cf80f50f6708d103afd56d23ae"]:
{{{
#!CommitTicketReference repository=""
revision="da5069f68f9ec0cf80f50f6708d103afd56d23ae"
Fixed #20134 -- Correct list of fields that UserManager requires.

Thanks semenov and pegler.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/20134#comment:2>

Django

unread,
Jul 4, 2013, 10:20:27 AM7/4/13
to django-...@googlegroups.com
#20134: UserManager documentation doesn't mention that it depends on date_joined
--------------------------------------+------------------------------------
Reporter: semenov | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.5

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"541a30c3768fa86ecb85ceea8545af175bada4fb"]:
{{{
#!CommitTicketReference repository=""
revision="541a30c3768fa86ecb85ceea8545af175bada4fb"
[1.6.x] Fixed #20134 -- Correct list of fields that UserManager requires.

Thanks semenov and pegler.

Backport of da5069f68f from master.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/20134#comment:3>

Django

unread,
Jul 4, 2013, 10:20:28 AM7/4/13
to django-...@googlegroups.com
#20134: UserManager documentation doesn't mention that it depends on date_joined
--------------------------------------+------------------------------------
Reporter: semenov | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.5

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"25d987b21e3af11b3ab3e37478a2dfd32f886d97"]:
{{{
#!CommitTicketReference repository=""
revision="25d987b21e3af11b3ab3e37478a2dfd32f886d97"
[1.5.x] Fixed #20134 -- Correct list of fields that UserManager requires.

Thanks semenov and pegler.

Backport of da5069f68f from master.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/20134#comment:4>

Reply all
Reply to author
Forward
0 new messages