[Django] #20793: Add Last-Modified header to generated sitemaps
Django
----------------------------------+------------------------------------
Reporter: julianb | Owner: nobody
Type: New feature | Status: new
Component: contrib.sitemaps | Version: 1.5
Severity: Normal | Keywords: sitemaps last modified
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------
From each items lastmod attribute, we can infer the lastmod of the whole
sitemap and set this as Last-Modified header for the sitemap. Google will
then request with an If-Modified-Since header and bytes are saved.
--
Ticket URL: <https://code.djangoproject.com/ticket/20793>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: julianb | Owner: julianb
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: 1.5
Severity: Normal | Resolution:
Keywords: sitemaps last | Triage Stage:
modified | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by julianb):
* status: new => assigned
* needs_better_patch: => 0
* owner: nobody => julianb
* needs_tests: => 0
* needs_docs: => 0
Comment:
https://github.com/django/django/pull/1391
--
Ticket URL: <https://code.djangoproject.com/ticket/20793#comment:1>
Django
Reporter: julianb | Owner: julianb
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: sitemaps last | Triage Stage: Accepted
modified | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 1 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by claudep):
* needs_tests: 0 => 1
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/20793#comment:2>
Django
Reporter: julianb | Owner: julianb
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: sitemaps last | Triage Stage: Accepted
modified | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by julianb):
* needs_tests: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/20793#comment:3>
Django
Reporter: julianb | Owner: julianb
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: sitemaps last | Triage Stage: Ready for
modified | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by claudep):
* version: 1.5 => master
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/20793#comment:4>
Django
Reporter: julianb | Owner: julianb
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: master
Severity: Normal | Resolution:
modified | Needs documentation: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
* stage: Ready for checkin => Accepted
Comment:
The current patch will add a Last-Modified header if any item if the feed
has a lastmod.
I would expect it to add the header only if all items have a lastmod.
As soon as one item doesn't have a lastmod you really can't say anything
about the entire feed.
--
Ticket URL: <https://code.djangoproject.com/ticket/20793#comment:5>
Django
Reporter: julianb | Owner: julianb
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: master
Severity: Normal | Resolution:
Keywords: sitemaps last | Triage Stage: Accepted
modified | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by julianb):
I added a fix for this case. It now keeps track if all items have a
lastmod.
--
Ticket URL: <https://code.djangoproject.com/ticket/20793#comment:6>
Django
Reporter: julianb | Owner: julianb
Component: contrib.sitemaps | Version: master
Severity: Normal | Resolution: fixed
Keywords: sitemaps last | Triage Stage: Accepted
modified | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"8f5533ab250df07ea84f98d39808806e282468a5"]:
{{{
#!CommitTicketReference repository=""
revision="8f5533ab250df07ea84f98d39808806e282468a5"
Fixed #20793 -- Added Last-Modified header to sitemaps.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20793#comment:7>