[Django] #27743: CSS fix of "viewsitelink", "golink" and "addlink" buttons for Django admin
Django
-------------------------------------+-------------------------------------
Reporter: Nick | Owner: nobody
Mavrakis |
Type: | Status: new
Cleanup/optimization |
Component: | Version: master
contrib.admin | Keywords: admin, css,
Severity: Normal | background-position, icon
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 1 |
-------------------------------------+-------------------------------------
This is a minor fix but, in my opinion, its very helpful!
Inside the Django admin change list page, in the upper right corner (ADD
OBJECT button), if the text is too long then the "+" icon overlaps the
text as you can see in the image. This is due to the `background-position:
93% center`
(https://github.com/django/django/blob/master/django/contrib/admin/static/admin/css/base.css#L741).
PROPOSED FIX: Because `background-position` can take up to 4 values due to
`background position edge offsets` (http://caniuse.com/#feat=css-
background-offsets), we can change the above line to:
`background-position: right 7px center;`
The same applies to the other button, `VIEW ON SITE`
(https://docs.djangoproject.com/en/dev/ref/contrib/admin/#django.contrib.admin.ModelAdmin.view_on_site),
as well.
--
Ticket URL: <https://code.djangoproject.com/ticket/27743>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, css, | Triage Stage:
background-position, icon | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
* Attachment "icon_not_align_right.png" added.
django admin list display view, "+" icon overlaps text
Django
-------------------------------------+-------------------------------------
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
background-position, icon |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):
* cc: elky (added)
* easy: 1 => 0
* stage: Unreviewed => Accepted
Comment:
ekly, could you review? Nick, could you create a pull request?
--
Ticket URL: <https://code.djangoproject.com/ticket/27743#comment:1>
Django
-------------------------------------+-------------------------------------
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, css, | Triage Stage: Accepted
background-position, icon |
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by elky):
`background-position: right 7px center;` fix is totally fine. It will work
well in all major browsers.
--
Ticket URL: <https://code.djangoproject.com/ticket/27743#comment:2>
Django
-------------------------------------+-------------------------------------
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, css, | Triage Stage: Accepted
background-position, icon |
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Nick Mavrakis):
Sure. I'll make a PR this afternoon!
--
Ticket URL: <https://code.djangoproject.com/ticket/27743#comment:3>
Django
-------------------------------------+-------------------------------------
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, css, | Triage Stage: Accepted
background-position, icon |
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Nick Mavrakis):
Pull request created ([https://github.com/django/django/pull/7914]). Thank
you!
--
Ticket URL: <https://code.djangoproject.com/ticket/27743#comment:4>
Django
-------------------------------------+-------------------------------------
Cleanup/optimization |
Component: contrib.admin | Version: master
Keywords: admin, css, | Triage Stage: Accepted
background-position, icon |
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"e5c2e43cc832028a974399af07a1c3ba6afa2467" e5c2e43]:
{{{
#!CommitTicketReference repository=""
revision="e5c2e43cc832028a974399af07a1c3ba6afa2467"
Fixed #27743 -- Prevented admin's "+" button icon from overlapping its
label.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27743#comment:5>
Django
-------------------------------------+-------------------------------------
Type: | Status: closed
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: admin, css, | Triage Stage: Accepted
background-position, icon |
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"fb55247d595088df455b3ef814e9366b3db1a4fe" fb55247d]:
{{{
#!CommitTicketReference repository=""
revision="fb55247d595088df455b3ef814e9366b3db1a4fe"
[1.11.x] Fixed #27743 -- Prevented admin's "+" button icon from
overlapping its label.
Backport of e5c2e43cc832028a974399af07a1c3ba6afa2467 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27743#comment:6>