Re: [Django] #6362: Remove blank spaces with strip when validating the data
Django
-------------------------------------+-------------------------------------
Reporter: marinho | Owner: nobody
Type: New | Status: new
feature | Component: Forms
Milestone: | Severity: Normal
Version: SVN | Keywords: blank space strip
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 0
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
-------------------------------------+-------------------------------------
Changes (by boxed):
* easy: => 0
Comment:
Spaces in various fields in the database screw up sorting too, which gets
reported as bugs because the spaces are of course not even shown by HTML.
It's also very hard to fix after the fact. Cron jobs that run strips on
all character fields on all your models? No thanks :P
--
Ticket URL: <https://code.djangoproject.com/ticket/6362#comment:38>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: marinho | Owner: nobody
Type: New | Status: new
feature | Component: Forms
Milestone: | Severity: Normal
Version: SVN | Keywords: blank space strip
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 0
Patch needs improvement: 1 |
-------------------------------------+-------------------------------------
Changes (by boxed):
* easy: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/6362#comment:39>
Django
-------------------------------------+-------------------------------------
Reporter: marinho | Owner: nobody
Type: New | Status: new
feature | Component: Forms
Milestone: | Severity: Normal
Version: SVN | Keywords: blank space strip
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 0
Patch needs improvement: 1 |
-------------------------------------+-------------------------------------
* easy: 1 => 0
Comment:
Replying to [comment:39 boxed]:
''Easy picking'' is a recently added nullable boolean-like flag for
tickets in our Trac instance that is reset to false with the first update
to the ticket after it got added. That is the reason it changes even when
you hadn't deactivated it explicitly. There is no need to set it back to
on.
--
Ticket URL: <https://code.djangoproject.com/ticket/6362#comment:40>
Django
-------------------------------------+-------------------------------------
Reporter: marinho | Owner: nobody
Type: New | Status: new
feature | Component: Forms
Milestone: | Severity: Normal
Version: SVN | Keywords: blank space strip
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 0
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
-------------------------------------+-------------------------------------
Changes (by alekam):
* cc: alex@… (added)
* ui_ux: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/6362#comment:41>
Django
-------------------------------------+-------------------------------------
Reporter: marinho | Owner: nobody
Type: New | Status: new
feature | Component: Forms
Milestone: | Severity: Normal
Version: SVN | Keywords: blank space strip
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 0
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
* cc: t.zander@… (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/6362#comment:42>
Django
-------------------------------------+-------------------------------------
Reporter: marinho | Owner: nobody
Milestone: | Severity: Normal
Version: SVN | Keywords: blank space strip
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => wontfix
Comment:
Silently discarding user input -- whether it's spaces or not -- isn't
something a framework ought to do. There are enough ways to do this in
user code, but if Django strips spaces there aren't any way to get them
back, so it's gotta stay this way.
I'd be slightly in favor of a normalization callback for fields (as
suggested above), or ''maybe'' some sort of "strip spaces" flag (but only
if done is a reasonable manner. If someone has a good proposal (hopefully
with a patch) here feel free to open a new ticket for it.
--
Ticket URL: <https://code.djangoproject.com/ticket/6362#comment:43>
Django
-------------------------------------+-------------------------------------
Reporter: marinho | Owner: nobody
Component: Forms | Version: master
Severity: Normal | Resolution: wontfix
Keywords: blank space strip | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by intgr):
* cc: marti@… (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/6362#comment:44>
Django
-------------------------------------+-------------------------------------
Reporter: marinho | Owner: nobody
Type: New feature | Status: closed
Component: Forms | Version: master
Severity: Normal | Resolution: wontfix
Keywords: blank space strip | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by anonymous):
It is really error prone to do the stripping manually. This should be
reconsidered.
--
Ticket URL: <https://code.djangoproject.com/ticket/6362#comment:45>
Django
-------------------------------------+-------------------------------------
Reporter: marinho | Owner: nobody
Type: New feature | Status: closed
Component: Forms | Version: master
Severity: Normal | Resolution: wontfix
Keywords: blank space strip | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by carbonXT):
FWIW, I agree with @jacob's decision that by default the framework
shouldn't be mucking with user input. However, since removing
leading/trailing whitespace is the desired behavior for I believe form
I've ever written... a 'strip spaces' flag would be helpful.
--
Ticket URL: <https://code.djangoproject.com/ticket/6362#comment:46>
Django
-------------------------------------+-------------------------------------
Reporter: marinho | Owner: nobody
Type: New feature | Status: closed
Component: Forms | Version: master
Severity: Normal | Resolution: wontfix
Keywords: blank space strip | Triage Stage: Design
Has patch: 1 | decision needed
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 1
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by jdufresne):
+1. I would really appreciate if this feature could be reconsidered.
Whether it is on by default or not, I don't care. Users are bypassing form
validation by entering spaces in required fields. This seems to throw away
the entire point.
--
Ticket URL: <https://code.djangoproject.com/ticket/6362#comment:47>
Django
-------------------------------------+-------------------------------------
Reporter: marinho | Owner: nobody
Type: New feature | Status: closed
Component: Forms | Version: master
Severity: Normal | Resolution: wontfix
Keywords: blank space strip | Triage Stage: Design
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by tomchristie):
Link to latest thread on the discussion group regarding this...
https://groups.google.com/d/msg/django-developers/D1GBj9VB9sk/gDm5PFHMKSUJ
--
Ticket URL: <https://code.djangoproject.com/ticket/6362#comment:48>