[Django] #27199: Integer inputs marked as type="text" instead of type="number"

12 views
Skip to first unread message

Django

unread,
Sep 8, 2016, 11:57:02 AM9/8/16
to django-...@googlegroups.com
#27199: Integer inputs marked as type="text" instead of type="number"
-------------------------------+--------------------
Reporter: renskiy | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------
This happens because of
'''django.contrib.admin.widgets.AdminIntegerFieldWidget''' inherits
TextInput instead of NumberInput.

--
Ticket URL: <https://code.djangoproject.com/ticket/27199>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 8, 2016, 12:02:15 PM9/8/16
to django-...@googlegroups.com
#27199: Integer inputs marked as type="text" instead of type="number"
-------------------------------+--------------------------------------
Reporter: renskiy | Owner: renskiy
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by renskiy):

* owner: nobody => renskiy
* needs_better_patch: => 0
* status: new => assigned
* needs_tests: => 0
* needs_docs: => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/27199#comment:1>

Django

unread,
Sep 8, 2016, 12:55:01 PM9/8/16
to django-...@googlegroups.com
#27199: Integer inputs marked as type="text" instead of type="number"
-------------------------------------+-------------------------------------

Reporter: renskiy | Owner: renskiy
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* has_patch: 0 => 1
* easy: 1 => 0
* stage: Unreviewed => Ready for checkin


Comment:

I thought maybe this wasn't changed intentionally given the concerns in
#19686 and #23075, but I didn't see any discussion so I think this is
fine. A mention in the release notes as a possible backwards-incompatible
change might be needed. [https://github.com/django/django/pull/7220 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/27199#comment:2>

Django

unread,
Sep 9, 2016, 9:43:02 AM9/9/16
to django-...@googlegroups.com
#27199: Integer inputs marked as type="text" instead of type="number"
-------------------------------------+-------------------------------------
Reporter: renskiy | Owner: renskiy
Type: Bug | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"ca9c69a9682141bc102ad6751f2feecc3d0d9d21" ca9c69a9]:
{{{
#!CommitTicketReference repository=""
revision="ca9c69a9682141bc102ad6751f2feecc3d0d9d21"
Fixed #27199 -- Made AdminIntegerFieldWidget use NumberInput.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27199#comment:3>

Reply all
Reply to author
Forward
0 new messages