[Django] #28504: Add hooks into schema alter_field and reduce complexity

7 views
Skip to first unread message

Django

unread,
Aug 17, 2017, 5:21:01 PM8/17/17
to django-...@googlegroups.com
#28504: Add hooks into schema alter_field and reduce complexity
-------------------------------------+-------------------------------------
Reporter: Rachel | Owner: nobody
Tobin |
Type: New | Status: new
feature |
Component: Database | Version: 1.11
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
This patch adds in hooks into the base `alter_field` method in
`BaseDatabaseSchemaEditor` so backends are able to augment or override the
various actions that occur when altering a field. This also cuts
complexity in half, and clarifies the various actions.

PR is https://github.com/django/django/pull/8922

--
Ticket URL: <https://code.djangoproject.com/ticket/28504>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 17, 2017, 5:31:55 PM8/17/17
to django-...@googlegroups.com
#28504: Add hooks into schema alter_field and reduce complexity
-------------------------------------+-------------------------------------
Reporter: Rachel Tobin | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: 1.11
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Rachel Tobin):

* type: New feature => Cleanup/optimization


--
Ticket URL: <https://code.djangoproject.com/ticket/28504#comment:1>

Django

unread,
Aug 21, 2017, 7:23:25 AM8/21/17
to django-...@googlegroups.com
#28504: Add hooks into SchemaEditor.alter_field() and reduce complexity
--------------------------------------+------------------------------------

Reporter: Rachel Tobin | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Migrations | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham):

* component: Database layer (models, ORM) => Migrations
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/28504#comment:2>

Django

unread,
Aug 22, 2017, 6:30:47 PM8/22/17
to django-...@googlegroups.com
#28504: Add hooks into SchemaEditor.alter_field() and reduce complexity
--------------------------------------+------------------------------------
Reporter: Rachel Tobin | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Migrations | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Rachel Tobin):

* cc: Rachel Tobin (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/28504#comment:3>

Django

unread,
Mar 14, 2018, 3:44:01 AM3/14/18
to django-...@googlegroups.com
#28504: Add hooks into SchemaEditor.alter_field() and reduce complexity
--------------------------------------+------------------------------------
Reporter: Rachel Tobin | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Migrations | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Carlton Gibson):

* has_patch: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/28504#comment:4>

Reply all
Reply to author
Forward
0 new messages