[Django] #28112: Forward time zone through geolocation wrapper

3 views
Skip to first unread message

Django

unread,
Apr 21, 2017, 4:02:52 AM4/21/17
to django-...@googlegroups.com
#28112: Forward time zone through geolocation wrapper
------------------------------------------------+--------------------------
Reporter: R3turnz | Owner: R3turnz
Type: Cleanup/optimization | Status: assigned
Component: GIS | Version: 1.11
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+--------------------------
The django.contrib.gis.geoip2 wrapper should forward the time zone exposed
by the geoip2 libary.

--
Ticket URL: <https://code.djangoproject.com/ticket/28112>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 21, 2017, 6:34:10 AM4/21/17
to django-...@googlegroups.com
#28112: Forward time zone through geolocation wrapper
-------------------------------------+-------------------------------------
Reporter: R3turnz | Owner: R3turnz
Type: | Status: assigned
Cleanup/optimization |
Component: GIS | Version: 1.11
Severity: Normal | Resolution:

Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by R3turnz:

Old description:

> The django.contrib.gis.geoip2 wrapper should forward the time zone
> exposed by the geoip2 libary.

New description:

The django.contrib.gis.geoip2 wrapper should forward the time zone exposed

by the geoip2 libary. This is the fixing
[https://github.com/R3turnz/django/fork] (pull request #8373)

--

--
Ticket URL: <https://code.djangoproject.com/ticket/28112#comment:1>

Django

unread,
Apr 21, 2017, 7:52:29 AM4/21/17
to django-...@googlegroups.com
#28112: Forward time zone through geolocation wrapper
--------------------------------------+------------------------------------

Reporter: R3turnz | Owner: R3turnz
Type: Cleanup/optimization | Status: assigned
Component: GIS | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham):

* needs_tests: 0 => 1
* stage: Unreviewed => Accepted


Old description:

> The django.contrib.gis.geoip2 wrapper should forward the time zone

> exposed by the geoip2 libary. This is the fixing

New description:

The `django.contrib.gis.geoip2` wrapper should forward the time zone
exposed by the geoip2 libary.

--

Comment:

[https://github.com/django/django/pull/8373 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/28112#comment:2>

Django

unread,
May 22, 2017, 9:07:10 PM5/22/17
to django-...@googlegroups.com
#28112: Added 'time_zone' in GeoIP2.city() dict
-------------------------------------+-------------------------------------
Reporter: R3turnz | Owner: R3turnz
Type: | Status: assigned
Cleanup/optimization |
Component: GIS | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Accepted => Ready for checkin
* needs_tests: 1 => 0


Comment:

I added a test and updated the docs.

--
Ticket URL: <https://code.djangoproject.com/ticket/28112#comment:3>

Django

unread,
May 22, 2017, 9:07:24 PM5/22/17
to django-...@googlegroups.com
#28112: Added 'time_zone' in GeoIP2.city() dict
-------------------------------------+-------------------------------------
Reporter: R3turnz | Owner: R3turnz
Type: | Status: closed
Cleanup/optimization |
Component: GIS | Version: 1.11
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"502f03d8970f94c0155b04e34532277523c08d9a" 502f03d8]:
{{{
#!CommitTicketReference repository=""
revision="502f03d8970f94c0155b04e34532277523c08d9a"
Fixed #28112 -- Added 'time_zone' in GeoIP2.city() dict.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28112#comment:4>

Reply all
Reply to author
Forward
0 new messages