[Django] #23894: Favor kwargs over args in migration serializer / deconstruct wherever possible

[Django]

#23894: Favor kwargs over args in migration serializer / deconstruct wherever
possible
--------------------------------------+--------------------
Reporter: MarkusH | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Migrations | Version: 1.7
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
For the same reasons as outlined in #23892 (forwards compatibility) Django
should use keyword arguments when serializing objects for migration files.
This allows potential positional argument removals in the future.

--
Ticket URL: <https://code.djangoproject.com/ticket/23894>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#23894: Favor kwargs over args in migration serializer / deconstruct wherever
possible

-------------------------------------+-------------------------------------
Reporter: MarkusH | Owner: MarkusH
Type: | Status: assigned
Cleanup/optimization | Version: 1.7
Component: Migrations | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by MarkusH):

* status: new => assigned
* needs_better_patch: => 0
* owner: nobody => MarkusH
* needs_tests: => 0
* needs_docs: => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/23894#comment:1>

[Django]

#23894: Favor kwargs over args in migration serializer / deconstruct wherever
possible

-------------------------------------+-------------------------------------
Reporter: MarkusH | Owner: MarkusH
Type: | Status: assigned
Cleanup/optimization | Version: 1.7
Component: Migrations | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Unreviewed

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by MarkusH):

* has_patch: 0 => 1

Comment:

I opened a pull request to unify the deconstruct methods:
https://github.com/django/django/pull/3603

--
Ticket URL: <https://code.djangoproject.com/ticket/23894#comment:2>

[Django]

#23894: Favor kwargs over args in migration serializer / deconstruct wherever
possible

-------------------------------------+-------------------------------------
Reporter: MarkusH | Owner: MarkusH
Type: | Status: assigned
Cleanup/optimization | Version: 1.7
Component: Migrations | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by carljm):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/23894#comment:3>

[Django]

#23894: Favor kwargs over args in migration serializer / deconstruct wherever
possible

--------------------------------------+------------------------------------
Reporter: MarkusH | Owner: MarkusH
Type: Cleanup/optimization | Status: assigned
Component: Migrations | Version: 1.7
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0

--------------------------------------+------------------------------------
Changes (by carljm):

* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/23894#comment:4>

[Django]

#23894: Favor kwargs over args in migration serializer / deconstruct wherever
possible

--------------------------------------+------------------------------------
Reporter: MarkusH | Owner: MarkusH
Type: Cleanup/optimization | Status: assigned

Component: Migrations | Version: 1.7

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0

--------------------------------------+------------------------------------
Changes (by MarkusH):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/23894#comment:5>

[Django]

#23894: Favor kwargs over args in migration serializer / deconstruct wherever
possible

-------------------------------------+-------------------------------------
Reporter: MarkusH | Owner: MarkusH

Type: | Status: assigned
Cleanup/optimization | Version: 1.7
Component: Migrations | Resolution:

Severity: Normal | Triage Stage: Ready for
Keywords: | checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by timgraham):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/23894#comment:6>

[Django]

#23894: Favor kwargs over args in migration serializer / deconstruct wherever
possible

-------------------------------------+-------------------------------------
Reporter: MarkusH | Owner: MarkusH

Type: | Status: closed
Cleanup/optimization | Version: 1.7
Component: Migrations | Resolution: fixed

Severity: Normal | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"912ad03226687dae91971ebd7e5cf87521f6b0de"]:
{{{
#!CommitTicketReference repository=""
revision="912ad03226687dae91971ebd7e5cf87521f6b0de"
Fixed #23894 -- Made deconstruct methods favor kwargs over args
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/23894#comment:7>