[Django] #27922: Add ErrorDict.get_json_data() method

5 views
Skip to first unread message

Django

unread,
Mar 9, 2017, 7:06:48 PM3/9/17
to django-...@googlegroups.com
#27922: Add ErrorDict.get_json_data() method
---------------------------------------+------------------------
Reporter: Tim Heap | Owner: nobody
Type: New feature | Status: new
Component: Forms | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
---------------------------------------+------------------------
This makes ErrorDict behave the same as ErrorList.
ErrorDict.get_json_data() is useful when incorporating form validation
errors inside a larger JSON response, where the JSON string output from
ErrorDict.as_json() would not be appropriate.

Tests and docs have been updated to include the new function.

See https://github.com/django/django/pull/8163

--
Ticket URL: <https://code.djangoproject.com/ticket/27922>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Mar 10, 2017, 8:11:05 AM3/10/17
to django-...@googlegroups.com
#27922: Add ErrorDict.get_json_data() method
-----------------------------+------------------------------------

Reporter: Tim Heap | Owner: nobody
Type: New feature | Status: new
Component: Forms | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-----------------------------+------------------------------------
Changes (by Tim Graham):

* needs_better_patch: 0 => 1
* stage: Unreviewed => Accepted


Comment:

Seems okay at first glance. Please review your patch using the
PatchReviewChecklist as a few requirements such as release notes and
versionadded annotations are missing.

--
Ticket URL: <https://code.djangoproject.com/ticket/27922#comment:1>

Django

unread,
Mar 12, 2017, 7:14:27 PM3/12/17
to django-...@googlegroups.com
#27922: Add ErrorDict.get_json_data() method
-----------------------------+------------------------------------
Reporter: Tim Heap | Owner: nobody
Type: New feature | Status: new
Component: Forms | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-----------------------------+------------------------------------

Comment (by Tim Heap):

I've added release notes to the 2.0 release document, and a versionadded:
2.0 note to the docs.

--
Ticket URL: <https://code.djangoproject.com/ticket/27922#comment:2>

Django

unread,
May 24, 2017, 10:07:28 PM5/24/17
to django-...@googlegroups.com
#27922: Add ErrorDict.get_json_data() method
-----------------------------+------------------------------------
Reporter: Tim Heap | Owner: nobody
Type: New feature | Status: new
Component: Forms | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------+------------------------------------
Changes (by Tim Heap):

* needs_better_patch: 1 => 0


Comment:

Is there anything else that needs adding to this patch?

--
Ticket URL: <https://code.djangoproject.com/ticket/27922#comment:3>

Django

unread,
May 27, 2017, 10:24:40 AM5/27/17
to django-...@googlegroups.com
#27922: Add ErrorDict.get_json_data() method
-----------------------------+------------------------------------
Reporter: Tim Heap | Owner: nobody
Type: New feature | Status: closed
Component: Forms | Version: 1.10
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------+------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"5b6181f4d58f63e7d2b52ab94e162e5ce8980f12" 5b6181f4]:
{{{
#!CommitTicketReference repository=""
revision="5b6181f4d58f63e7d2b52ab94e162e5ce8980f12"
Fixed #27922 -- Added ErrorDict.get_json_data().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27922#comment:4>

Django

unread,
May 28, 2017, 11:34:12 PM5/28/17
to django-...@googlegroups.com
#27922: Add ErrorDict.get_json_data() method
-----------------------------+------------------------------------
Reporter: Tim Heap | Owner: nobody
Type: New feature | Status: closed
Component: Forms | Version: 1.10

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------+------------------------------------

Comment (by Tim Heap):

Thanks!

--
Ticket URL: <https://code.djangoproject.com/ticket/27922#comment:5>

Reply all
Reply to author
Forward
0 new messages