[Django] #27583: MultiValueDict raises TypeError when

11 views
Skip to first unread message

Django

unread,
Dec 9, 2016, 4:16:37 AM12/9/16
to django-...@googlegroups.com
#27583: MultiValueDict raises TypeError when
--------------------------------------+--------------------------
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: assigned
Component: Utilities | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
--------------------------------------+--------------------------
`django.utils.datastructures.MultiValueDict` raises:

{{{
File "django/utils/datastructures.py", line 149, in _getlist
values = list(values)
TypeError: 'NoneType' object is not iterable
}}}

in `getlist` method when `force_list` is on and `values` for specific
`key` is `None`.

--
Ticket URL: <https://code.djangoproject.com/ticket/27583>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Dec 9, 2016, 4:17:00 AM12/9/16
to django-...@googlegroups.com
#27583: MultiValueDict raises TypeError when values for specific key is None
---------------------------+--------------------------------------

Reporter: felixxm | Owner: felixxm
Type: Bug | Status: assigned
Component: Utilities | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
---------------------------+--------------------------------------

--
Ticket URL: <https://code.djangoproject.com/ticket/27583#comment:1>

Django

unread,
Dec 9, 2016, 4:25:34 AM12/9/16
to django-...@googlegroups.com
#27583: MultiValueDict raises TypeError when values for specific key is None
--------------------------------+--------------------------------------

Reporter: felixxm | Owner: felixxm
Type: Bug | Status: assigned
Component: Utilities | Version: master
Severity: Normal | Resolution:
Keywords: MultiValueDict | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------+--------------------------------------
Changes (by felixxm):

* keywords: => MultiValueDict
* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/7669 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/27583#comment:2>

Django

unread,
Dec 9, 2016, 3:31:01 PM12/9/16
to django-...@googlegroups.com
#27583: MultiValueDict raises TypeError when values for specific key is None
-------------------------------------+-------------------------------------

Reporter: felixxm | Owner: felixxm
Type: Bug | Status: assigned
Component: Utilities | Version: master
Severity: Normal | Resolution:
Keywords: MultiValueDict | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Unreviewed => Ready for checkin


Comment:

It's a regression in #27198 that only affects master.

--
Ticket URL: <https://code.djangoproject.com/ticket/27583#comment:3>

Django

unread,
Dec 9, 2016, 3:32:22 PM12/9/16
to django-...@googlegroups.com
#27583: MultiValueDict raises TypeError when values for specific key is None
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: felixxm
Type: Bug | Status: closed
Component: Utilities | Version: master
Severity: Normal | Resolution: fixed

Keywords: MultiValueDict | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"8e3a72f4fb4e9d3f93c7d966c13d4e7446b1949e" 8e3a72f]:
{{{
#!CommitTicketReference repository=""
revision="8e3a72f4fb4e9d3f93c7d966c13d4e7446b1949e"
Fixed #27583 -- Fixed MultiValueDict.getlist() crash when values for key
is None.

Restored the behavior before 727d7ce6cba21363470aaefb2dc5353017531be3.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27583#comment:4>

Reply all
Reply to author
Forward
0 new messages