[Django] #30117: Add support for mysqlclient 1.4.0
Django
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: felixxm
Type: | Status: assigned
Cleanup/optimization |
Component: Database | Version: 2.2
layer (models, ORM) |
Severity: Normal | Keywords: mysql mysqclient
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Three tests are failing with `mysqlclient==1.4.0` (see
[https://github.com/PyMySQL/mysqlclient-python/blob/master/HISTORY.rst
#whats-new-in-140 release notes]):
- `backends.mysql.test_schema.SchemaEditorTests.test_quote_value
(value=False)`,
- `backends.tests.BackendTestCase.test_cursor_execute_with_pyformat`,
- `raw_query.tests.RawQueryTests.test_pyformat_params`
on both MySQL and MariaDB.
--
Ticket URL: <https://code.djangoproject.com/ticket/30117>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: felixxm
Type: | Status: assigned
Cleanup/optimization |
(models, ORM) |
Severity: Normal | Resolution:
Keywords: mysql mysqclient | Triage Stage:
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by felixxm):
I created issue in the `mysqlclient` due to the crash of
`cursor.execute()` when passing mapping as args (see
[https://github.com/PyMySQL/mysqlclient-python/issues/323 mysqlclient-
python-323]).
--
Ticket URL: <https://code.djangoproject.com/ticket/30117#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: felixxm
Type: | Status: assigned
Cleanup/optimization |
(models, ORM) |
Severity: Normal | Resolution:
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Carlton Gibson):
Do we need to pin to 1.3.14 in the meantime?
--
Ticket URL: <https://code.djangoproject.com/ticket/30117#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: felixxm
Type: | Status: assigned
Cleanup/optimization |
(models, ORM) |
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/10865 PR]
I don't think so. `mysqlclient==1.4.1` is already released.
--
Ticket URL: <https://code.djangoproject.com/ticket/30117#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: felixxm
Type: | Status: assigned
Cleanup/optimization |
(models, ORM) |
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/30117#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: felixxm
Type: | Status: assigned
Cleanup/optimization |
(models, ORM) |
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
--
Ticket URL: <https://code.djangoproject.com/ticket/30117#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: felixxm | Owner: felixxm
Type: | Status: assigned
Cleanup/optimization |
(models, ORM) |
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
--
Ticket URL: <https://code.djangoproject.com/ticket/30117#comment:6>
Django
Reporter: felixxm | Owner: felixxm
Cleanup/optimization |
Component: Database layer | Version: 2.2
(models, ORM) |
Keywords: mysql mysqclient | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"f05c02c4b8d4e423e57d453c4bd699dc5ff7eaa7" f05c02c]:
{{{
#!CommitTicketReference repository=""
revision="f05c02c4b8d4e423e57d453c4bd699dc5ff7eaa7"
Fixed #30117 -- Fixed SchemaEditor.quote_value() test for mysqlclient
1.4.0+.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30117#comment:7>
Django
Reporter: felixxm | Owner: felixxm
Cleanup/optimization |
Component: Database layer | Version: 2.2
(models, ORM) |
Severity: Normal | Resolution: fixed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"70aeb6ab016612ddb50be75a3210250a184200ec" 70aeb6ab]:
{{{
#!CommitTicketReference repository=""
revision="70aeb6ab016612ddb50be75a3210250a184200ec"
[2.2.x] Fixed #30117 -- Fixed SchemaEditor.quote_value() test for
mysqlclient 1.4.0+.
Backport of f05c02c4b8d4e423e57d453c4bd699dc5ff7eaa7 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30117#comment:8>
Django
Reporter: felixxm | Owner: felixxm
Cleanup/optimization |
Component: Database layer | Version: 2.2
(models, ORM) |
Severity: Normal | Resolution: fixed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"03219b5f709dcd5b0bfacd963508625557ec1ef0" 03219b5f]:
{{{
#!CommitTicketReference repository=""
revision="03219b5f709dcd5b0bfacd963508625557ec1ef0"
[2.1.x] Fixed #30117 -- Fixed SchemaEditor.quote_value() test for
mysqlclient 1.4.0+.
Backport of f05c02c4b8d4e423e57d453c4bd699dc5ff7eaa7 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30117#comment:9>