--
Ticket URL: <https://code.djangoproject.com/ticket/25326>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
Pull request: https://github.com/django/django/pull/5206
--
Ticket URL: <https://code.djangoproject.com/ticket/25326#comment:1>
Comment (by dodobas):
Couple of remarks:
* examples are Python2 as `'id': 54360982L`, in Python3 all integers are
implemented as `long` integers and as we are pushing Python3, we should
probably change it
* as `cursors` are iterable examples could be improved in a way to not use
`fetchall()` but return a generator, and then use list comprehensions to
actually ''show'' the difference between approaches
--
Ticket URL: <https://code.djangoproject.com/ticket/25326#comment:2>
* needs_better_patch: 0 => 1
* has_patch: 0 => 1
* type: Uncategorized => New feature
* stage: Unreviewed => Accepted
Comment:
Looks reasonable, but docs should assume Python 3. Haven't taken time to
understand point 2, but if you want to make those updates as a separate
commit, I'll take a look. After you make the updates, please uncheck
"Patch needs improvement" on the ticket so it returns to the review queue.
Thanks!
--
Ticket URL: <https://code.djangoproject.com/ticket/25326#comment:3>
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/25326#comment:4>
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"5ab65ca5c900557f508f62a260f9ea53d9d93f37" 5ab65ca5]:
{{{
#!CommitTicketReference repository=""
revision="5ab65ca5c900557f508f62a260f9ea53d9d93f37"
Fixed #25326 -- Added namedtuple example for executing custom SQL.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25326#comment:5>
Comment (by Tim Graham <timograham@…>):
In [changeset:"5ed9616a09679f1b03fd4421c5adbfab17c74efc" 5ed9616]:
{{{
#!CommitTicketReference repository=""
revision="5ed9616a09679f1b03fd4421c5adbfab17c74efc"
[1.8.x] Fixed #25326 -- Added namedtuple example for executing custom SQL.
Backport of 5ab65ca5c900557f508f62a260f9ea53d9d93f37 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25326#comment:6>