[Django] #27347: Contributing docs: Patch vs Pull-Request

3 views
Skip to first unread message

Django

unread,
Oct 14, 2016, 4:37:38 AM10/14/16
to django-...@googlegroups.com
#27347: Contributing docs: Patch vs Pull-Request
--------------------------------+--------------------
Reporter: Thomas Güttler | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+--------------------
I don't understand why this approach gets used in the contributing docs:

git clone https://github.com/django/django.git
...
pip install -e /path/to/your/local/clone/django/
...
git diff > 24788.diff

See https://docs.djangoproject.com/en/1.10/intro/contributing/

I guess you prefer pull requests, since they are easier to handle.

Why not take this approach?

fork django to personal github account via github web gui
...
pip install -e
git+https://github.com/mygithubnickname/django.git#egg=django
...
create pull request.

--
Ticket URL: <https://code.djangoproject.com/ticket/27347>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 14, 2016, 7:14:44 AM10/14/16
to django-...@googlegroups.com
#27347: Contributing docs: Patch vs Pull-Request
-------------------------------------+-------------------------------------

Reporter: Thomas Güttler | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: 1.10
Severity: Normal | Resolution: duplicate
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* status: new => closed
* needs_better_patch: => 0
* component: Uncategorized => Documentation
* resolution: => duplicate
* needs_tests: => 0
* needs_docs: => 0
* type: Uncategorized => Cleanup/optimization


Comment:

Duplicate of #26708.

--
Ticket URL: <https://code.djangoproject.com/ticket/27347#comment:1>

Django

unread,
Oct 14, 2016, 7:20:00 AM10/14/16
to django-...@googlegroups.com
#27347: Contributing docs: Patch vs Pull-Request
-------------------------------------+-------------------------------------

Reporter: Thomas Güttler | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: 1.10
Severity: Normal | Resolution: duplicate
Keywords: | Triage Stage:
| Unreviewed

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Thomas Güttler):

Thank you Graham. I guess only few people have the overview like you have.
(and: sorry, I have not seen that this has been reported before).

--
Ticket URL: <https://code.djangoproject.com/ticket/27347#comment:2>

Reply all
Reply to author
Forward
0 new messages