[Django] #24491: Admin's "no" icon is incorrect and should be replaced

10 views
Skip to first unread message

Django

unread,
Mar 16, 2015, 9:19:02 AM3/16/15
to django-...@googlegroups.com
#24491: Admin's "no" icon is incorrect and should be replaced
-------------------------------+--------------------
Reporter: EvilDMP | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.7
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------
The admin uses pretty yes/no icons:

* yes,
https://github.com/django/django/blob/master/django/contrib/admin/static/admin/img
/icon-yes.gif, which displays as
[[Image(https://github.com/django/django/blob/master/django/contrib/admin/static/admin/img
/icon-yes.gif?raw=true)]]
* no,
https://github.com/django/django/blob/master/django/contrib/admin/static/admin/img
/icon-no.gif, which displays as
[[Image(https://github.com/django/django/blob/master/django/contrib/admin/static/admin/img
/icon-no.gif?raw=true)]]

The "no" icon is incorrect;
[[Image(https://github.com/django/django/blob/master/django/contrib/admin/static/admin/img
/icon-no.gif?raw=true)]] means "no entry", not "no".

This leads to some confusing interface cases: a boolean field called
"locked" or "restricted" for example, will show a no entry sign when an
item is **not** locked or restricted - the sign itself denotes restricted
access to something.

While the "yes" tick is commonly-recognised, there is no good symbol for
"no" - most negative symbols denote prohibition, and I can't think of any
that imply simple negation.

Even a red cross in a box [x] isn't adequate, because crosses are also
used to check boxes in many interfaces, and some people are red-green
colourblind.

My suggestion is to change both symbols, so that "yes" is a green tick in
a green box, and and "no" is an unticked red box.

--
Ticket URL: <https://code.djangoproject.com/ticket/24491>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Mar 16, 2015, 9:29:20 AM3/16/15
to django-...@googlegroups.com
#24491: Admin's "no" icon is incorrect and should be replaced
-------------------------------+--------------------------------------
Reporter: EvilDMP | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.7
Severity: Normal | Resolution: duplicate
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by timgraham):

* status: new => closed
* needs_better_patch: => 0
* resolution: => duplicate
* needs_tests: => 0
* needs_docs: => 0


Comment:

Could you raise this as part of the work elky is doing on the "new look"?
https://groups.google.com/d/msg/django-developers/HJAikaEBqJ4/L6pU8iIi6uMJ

As this change will require updating the documentation screenshots in
ref/contrib/admin/index.txt and intro/tutorial02.txt, it seems like a good
opportunity to combine efforts.

--
Ticket URL: <https://code.djangoproject.com/ticket/24491#comment:1>

Django

unread,
Mar 16, 2015, 5:44:15 PM3/16/15
to django-...@googlegroups.com
#24491: Admin's "no" icon is incorrect and should be replaced
-------------------------------+--------------------------------------
Reporter: EvilDMP | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.7
Severity: Normal | Resolution: duplicate
Keywords: | Triage Stage: Unreviewed

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------

Comment (by EvilDMP):

I've raised it there - https://github.com/elky/django-flat-theme/issues/3
- but I don't think it should depend on that (what if that project stalls,
for example?).

--
Ticket URL: <https://code.djangoproject.com/ticket/24491#comment:2>

Django

unread,
Mar 16, 2015, 7:12:37 PM3/16/15
to django-...@googlegroups.com
#24491: Admin's "no" icon is incorrect and should be replaced
-------------------------------+--------------------------------------
Reporter: EvilDMP | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.7
Severity: Normal | Resolution: duplicate
Keywords: | Triage Stage: Unreviewed

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------

Comment (by timgraham):

I expect it will be merged in a matter of weeks. If not, I'll consider
reopening this ticket. I'd rather not create conflicts/duplicated effort
by leaving this open and tempting someone to pick it up now.

--
Ticket URL: <https://code.djangoproject.com/ticket/24491#comment:3>

Reply all
Reply to author
Forward
0 new messages