[Django] #23911: support buffers as file-upload in the test client

39 views
Skip to first unread message

Django

unread,
Nov 25, 2014, 6:12:02 AM11/25/14
to django-...@googlegroups.com
#23911: support buffers as file-upload in the test client
-----------------------------------+--------------------
Reporter: tanner | Owner: nobody
Type: Uncategorized | Status: new
Component: Testing framework | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------
This patch renders the use of NamedTemporaryFile for file upload testing
unnecessary
https://github.com/django/django/pull/3617

--
Ticket URL: <https://code.djangoproject.com/ticket/23911>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Nov 25, 2014, 6:12:31 AM11/25/14
to django-...@googlegroups.com
#23911: support buffers as file-upload in the test client
-----------------------------------+--------------------------------------
Reporter: tanner | Owner: nobody
Type: New feature | Status: new

Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
Changes (by tanner):

* needs_docs: => 0
* type: Uncategorized => New feature
* needs_tests: => 0
* needs_better_patch: => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/23911#comment:1>

Django

unread,
Nov 27, 2014, 8:56:04 AM11/27/14
to django-...@googlegroups.com
#23911: support buffers as file-upload in the test client
-----------------------------------+------------------------------------
Reporter: tanner | Owner: nobody
Type: New feature | Status: new

Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
Changes (by timgraham):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/23911#comment:2>

Django

unread,
Nov 28, 2014, 8:21:05 AM11/28/14
to django-...@googlegroups.com
#23911: support buffers as file-upload in the test client
-----------------------------------+------------------------------------
Reporter: tanner | Owner: nobody
Type: New feature | Status: new

Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
Changes (by timgraham):

* needs_docs: 0 => 1


Comment:

Please uncheck "Needs documentation" when the patch is updated per
comments on the PR, thanks!

--
Ticket URL: <https://code.djangoproject.com/ticket/23911#comment:3>

Django

unread,
Nov 29, 2014, 11:55:49 AM11/29/14
to django-...@googlegroups.com
#23911: support buffers as file-upload in the test client
-----------------------------------+------------------------------------
Reporter: tanner | Owner: nobody
Type: New feature | Status: new

Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
Changes (by tanner):

* needs_docs: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/23911#comment:4>

Django

unread,
Dec 3, 2014, 1:33:42 PM12/3/14
to django-...@googlegroups.com
#23911: support buffers as file-upload in the test client
-----------------------------------+------------------------------------
Reporter: tanner | Owner: nobody
Type: New feature | Status: new

Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
Changes (by timgraham):

* needs_better_patch: 0 => 1


Comment:

Comments for improvement left on the PR.

--
Ticket URL: <https://code.djangoproject.com/ticket/23911#comment:5>

Django

unread,
Dec 4, 2014, 4:18:17 AM12/4/14
to django-...@googlegroups.com
#23911: support buffers as file-upload in the test client
-----------------------------------+------------------------------------
Reporter: tanner | Owner: nobody
Type: New feature | Status: new

Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
Changes (by tanner):

* needs_better_patch: 1 => 0


Comment:

ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/23911#comment:6>

Django

unread,
Dec 4, 2014, 7:01:33 AM12/4/14
to django-...@googlegroups.com
#23911: support buffers as file-upload in the test client
-------------------------------------+-------------------------------------
Reporter: tanner | Owner: nobody
Type: New feature | Status: new

Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
Has patch: 1 | checkin
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/23911#comment:7>

Django

unread,
Dec 4, 2014, 7:42:48 AM12/4/14
to django-...@googlegroups.com
#23911: support buffers as file-upload in the test client
-------------------------------------+-------------------------------------
Reporter: tanner | Owner: nobody
Type: New feature | Status: closed

Component: Testing framework | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
Has patch: 1 | checkin
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"018d110ef547acb71b0526d0ff934e1e476244e4"]:
{{{
#!CommitTicketReference repository=""
revision="018d110ef547acb71b0526d0ff934e1e476244e4"
Fixed #23911 -- Added support for buffer file uploads in the test client
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/23911#comment:8>

Reply all
Reply to author
Forward
0 new messages