[Django] #27842: class GenericSitemap doesn't handle "protocol" in __init__
Django
-------------------------------------+-------------------------------------
Reporter: chex | Owner: nobody
Type: | Status: new
Uncategorized |
Component: | Version: 1.10
contrib.sitemaps | Keywords: sitemaps
Severity: Normal | genericsitemap
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
django.contrib.sitemaps.GenericSitemap doesn't accept "protocol" in
initial args and kwargs.
{{{
some_sitemap = GenericSitemap(
info_dict={
'queryset': SomeModel.objects.all(),
},
priority=0.6,
changefreq='yearly',
)
some_sitemap.protocol = 'https'
}}}
\\
[https://docs.djangoproject.com/en/stable/_modules/django/contrib/sitemaps/#GenericSitemap
GenericSitemap source]
Why not to pass protocol in info_dict argument?
Thx.
--
Ticket URL: <https://code.djangoproject.com/ticket/27842>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: chex | Owner: nobody
Component: contrib.sitemaps | Version: 1.10
Severity: Normal | Resolution:
Keywords: sitemaps | Triage Stage:
genericsitemap | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Old description:
> django.contrib.sitemaps.GenericSitemap doesn't accept "protocol" in
> initial args and kwargs.
>
> {{{
> some_sitemap = GenericSitemap(
> info_dict={
> 'queryset': SomeModel.objects.all(),
> },
> priority=0.6,
> changefreq='yearly',
> )
> some_sitemap.protocol = 'https'
> }}}
> \\
> [https://docs.djangoproject.com/en/stable/_modules/django/contrib/sitemaps/#GenericSitemap
> GenericSitemap source]
> Why not to pass protocol in info_dict argument?
> Thx.
New description:
django.contrib.sitemaps.GenericSitemap doesn't accept "protocol" in
initial args and kwargs.
{{{
some_sitemap = GenericSitemap(
info_dict={
'queryset': SomeModel.objects.all(),
},
priority=0.6,
changefreq='yearly',
)
some_sitemap.protocol = 'https'
}}}
\\
[https://docs.djangoproject.com/en/stable/_modules/django/contrib/sitemaps/#GenericSitemap
GenericSitemap source]
Why not to pass protocol in info_dict argument?
--
--
Ticket URL: <https://code.djangoproject.com/ticket/27842#comment:1>
Django
-------------------------------------+-------------------------------------
Type: Uncategorized | Status: assigned
Component: contrib.sitemaps | Version: 1.10
Severity: Normal | Resolution:
Keywords: sitemaps | Triage Stage:
genericsitemap | Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: nobody => chex
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/27842#comment:2>
Django
-------------------------------------+-------------------------------------
Type: Uncategorized | Status: assigned
Component: contrib.sitemaps | Version: 1.10
Severity: Normal | Resolution:
Keywords: sitemaps | Triage Stage:
genericsitemap | Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Old description:
> django.contrib.sitemaps.GenericSitemap doesn't accept "protocol" in
> initial args and kwargs.
>
> {{{
> some_sitemap = GenericSitemap(
> info_dict={
> 'queryset': SomeModel.objects.all(),
> },
> priority=0.6,
> changefreq='yearly',
> )
> some_sitemap.protocol = 'https'
> }}}
> \\
> [https://docs.djangoproject.com/en/stable/_modules/django/contrib/sitemaps/#GenericSitemap
> GenericSitemap source]
> Why not to pass protocol in info_dict argument?
New description:
django.contrib.sitemaps.GenericSitemap doesn't accept "protocol" in
initial args and kwargs.
{{{
some_sitemap = GenericSitemap(
info_dict={
'queryset': SomeModel.objects.all(),
},
priority=0.6,
changefreq='yearly',
)
some_sitemap.protocol = 'https'
}}}
\\
[https://docs.djangoproject.com/en/1.10/_modules/django/contrib/sitemaps/#GenericSitemap
GenericSitemap source]
Why not to pass protocol in info_dict argument?
--
--
Ticket URL: <https://code.djangoproject.com/ticket/27842#comment:3>
Django
-------------------------------------+-------------------------------------
Type: Uncategorized | Status: assigned
Component: contrib.sitemaps | Version: 1.10
Severity: Normal | Resolution:
Keywords: sitemaps | Triage Stage:
genericsitemap | Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by chex):
[https://github.com/django/django/pull/8065 pr]
--
Ticket URL: <https://code.djangoproject.com/ticket/27842#comment:4>
Django
-------------------------------------+-------------------------------------
Type: Uncategorized | Status: assigned
Component: contrib.sitemaps | Version: 1.10
Severity: Normal | Resolution:
Keywords: sitemaps | Triage Stage:
genericsitemap | Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/27842#comment:5>
Django
-------------------------------------+-------------------------------------
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: 1.10
Severity: Normal | Resolution:
genericsitemap |
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_docs: 0 => 1
* type: Uncategorized => New feature
* needs_tests: 0 => 1
* stage: Unreviewed => Accepted
Comment:
Looks okay at first glance. Documentation and tests are also required.
--
Ticket URL: <https://code.djangoproject.com/ticket/27842#comment:6>
Django
-------------------------------------+-------------------------------------
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: 1.10
Severity: Normal | Resolution:
Keywords: sitemaps | Triage Stage: Accepted
genericsitemap |
Has patch: 1 | Needs documentation: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by chex):
Update [https://github.com/django/django/pull/8065 PR] with tests.
--
Ticket URL: <https://code.djangoproject.com/ticket/27842#comment:7>
Django
-------------------------------------+-------------------------------------
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: 1.10
Severity: Normal | Resolution:
Keywords: sitemaps | Triage Stage: Accepted
genericsitemap |
Has patch: 1 | Needs documentation: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham):
And documentation? Please update the ticket flags when you update the
patch. It looks like the tests are testing more than just what's changed.
It's fine to increase test coverage but please do it in a separate commit
(perhaps a separate PR that precedes this one).
--
Ticket URL: <https://code.djangoproject.com/ticket/27842#comment:8>
Django
-------------------------------------+-------------------------------------
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: 1.10
Severity: Normal | Resolution:
Keywords: sitemaps | Triage Stage: Accepted
genericsitemap |
Has patch: 1 | Needs documentation: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_tests: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/27842#comment:9>
Django
-------------------------------------+-------------------------------------
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: 1.10
Severity: Normal | Resolution:
Keywords: sitemaps | Triage Stage: Accepted
genericsitemap |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_docs: 1 => 0
Comment:
Update [https://github.com/django/django/pull/8065 pr] with documentation.
Non specific to the ticket tests are moved to another
[https://github.com/django/django/pull/8075 pr].
--
Ticket URL: <https://code.djangoproject.com/ticket/27842#comment:10>
Django
-------------------------------------+-------------------------------------
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: 1.10
Severity: Normal | Resolution:
Keywords: sitemaps | Triage Stage: Accepted
genericsitemap |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Old description:
> django.contrib.sitemaps.GenericSitemap doesn't accept "protocol" in
> initial args and kwargs.
>
> {{{
> some_sitemap = GenericSitemap(
> info_dict={
> 'queryset': SomeModel.objects.all(),
> },
> priority=0.6,
> changefreq='yearly',
> )
> some_sitemap.protocol = 'https'
> }}}
> \\
> [https://docs.djangoproject.com/en/1.10/_modules/django/contrib/sitemaps/#GenericSitemap
> GenericSitemap source]
> Why not to pass protocol in info_dict argument?
New description:
django.contrib.sitemaps.GenericSitemap doesn't accept "protocol" in
initial args or kwargs.
{{{
some_sitemap = GenericSitemap(
info_dict={
'queryset': SomeModel.objects.all(),
},
priority=0.6,
changefreq='yearly',
)
some_sitemap.protocol = 'https'
}}}
\\
[https://docs.djangoproject.com/en/1.10/_modules/django/contrib/sitemaps/#GenericSitemap
GenericSitemap source]
Why not to pass protocol as keyword argument?
some_sitemap = GenericSitemap(
info_dict={
'queryset': SomeModel.objects.all(),
},
priority=0.6,
changefreq='yearly',
protocol='https',
)
}}}
--
--
Ticket URL: <https://code.djangoproject.com/ticket/27842#comment:11>
Django
-------------------------------------+-------------------------------------
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: 1.10
Severity: Normal | Resolution:
Keywords: sitemaps | Triage Stage: Accepted
genericsitemap |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Old description:
> django.contrib.sitemaps.GenericSitemap doesn't accept "protocol" in
> initial args or kwargs.
>
> {{{
> some_sitemap = GenericSitemap(
> info_dict={
> 'queryset': SomeModel.objects.all(),
> },
> priority=0.6,
> changefreq='yearly',
> )
> some_sitemap.protocol = 'https'
> }}}
> \\
> [https://docs.djangoproject.com/en/1.10/_modules/django/contrib/sitemaps/#GenericSitemap
> GenericSitemap source]
> Why not to pass protocol as keyword argument?
>
> some_sitemap = GenericSitemap(
> info_dict={
> 'queryset': SomeModel.objects.all(),
> },
> priority=0.6,
> changefreq='yearly',
> protocol='https',
> )
> }}}
New description:
django.contrib.sitemaps.GenericSitemap doesn't accept "protocol" in
initial args or kwargs.
{{{
some_sitemap = GenericSitemap(
info_dict={
'queryset': SomeModel.objects.all(),
},
priority=0.6,
changefreq='yearly',
)
some_sitemap.protocol = 'https'
}}}
\\
[https://docs.djangoproject.com/en/1.10/_modules/django/contrib/sitemaps/#GenericSitemap
GenericSitemap source]
Why not to pass protocol as keyword argument?
{{{
some_sitemap = GenericSitemap(
info_dict={
'queryset': SomeModel.objects.all(),
},
priority=0.6,
changefreq='yearly',
protocol='https',
)
}}}
--
--
Ticket URL: <https://code.djangoproject.com/ticket/27842#comment:12>
Django
-------------------------------------+-------------------------------------
Reporter: chex | Owner: chex
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: 1.10
Severity: Normal | Resolution:
genericsitemap | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/27842#comment:13>
Django
-------------------------------------+-------------------------------------
Reporter: chex | Owner: chex
Component: contrib.sitemaps | Version: 1.10
Severity: Normal | Resolution: fixed
Keywords: sitemaps | Triage Stage: Ready for
genericsitemap | checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"9f21e35100b022b31fe723323db85c2cb28b16b8" 9f21e35]:
{{{
#!CommitTicketReference repository=""
revision="9f21e35100b022b31fe723323db85c2cb28b16b8"
Fixed #27842 -- Added protocol kwarg to GenericSitemap.__init__().
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27842#comment:14>