[Django] #26779: i18n_javascript should take extra_context as argument
Django
-------------------------------+--------------------
Reporter: shabda | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.9
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------
All Django admin views connected to urlpatterns take extra_context as
argument. So you can say `url(r'^admin/', include(admin.site.urls),
{'extra_context': {"foo": "bar"}})` except that it will break for jsi18n
endpoint.
This can be fixed by making i18n_javascript view take extra_context.
--
Ticket URL: <https://code.djangoproject.com/ticket/26779>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: shabda | Owner: shabda
Type: Bug | Status: assigned
Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by shabda):
* owner: nobody => shabda
* needs_better_patch: => 0
* status: new => assigned
* needs_tests: => 0
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/26779#comment:1>
Django
Reporter: shabda | Owner: shabda
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by shabda):
Patch is:
https://github.com/django/django/pull/6806
--
Ticket URL: <https://code.djangoproject.com/ticket/26779#comment:2>
Django
Reporter: shabda | Owner: shabda
Type: Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by timgraham):
* type: Bug => Cleanup/optimization
* needs_tests: 0 => 1
* stage: Unreviewed => Accepted
Comment:
A test is also needed.
--
Ticket URL: <https://code.djangoproject.com/ticket/26779#comment:3>
Django
Reporter: shabda | Owner: shabda
Type: Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by tobiasmcnulty):
* needs_better_patch: 0 => 1
* needs_tests: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/26779#comment:4>
Django
Reporter: shabda | Owner: shabda
Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"b0acb1e73ef32e368a8a6213e300e66981f976d7" b0acb1e7]:
{{{
#!CommitTicketReference repository=""
revision="b0acb1e73ef32e368a8a6213e300e66981f976d7"
Fixed #26779 -- Added extra_context parameter to admin's i18n_javascript
view.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26779#comment:5>