[Django] #31822: Add support for item_comments dynamic attribute
Django
-------------------------------------+-------------------------------------
Reporter: Viktor | Owner: Viktor Garske
Garske |
Type: New | Status: assigned
feature |
Component: | Version: 3.0
contrib.syndication |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
Add ''comments'' argument to {{{ feed.add_item() }}} in syndication.views
so that {{{ item_comments }}} can be defined directly without having to
take the detour via {{{ item_extra_kwargs }}}.
Additionally, ''comments'' is already explicitly mentioned in the
feedparser, but not implemented in the view.
--
Ticket URL: <https://code.djangoproject.com/ticket/31822>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
| Garske
Type: New feature | Status: assigned
Component: contrib.syndication | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/31822#comment:1>
Django
-------------------------------------+-------------------------------------
| Garske
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* version: 3.0 => master
--
Ticket URL: <https://code.djangoproject.com/ticket/31822#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Viktor Garske | Owner: Viktor
| Garske
Type: New feature | Status: assigned
Component: contrib.syndication | Version: master
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Unreviewed => Accepted
Comment:
Sounds reasonable, see
[http://validator.w3.org/feed/docs/rss2.html#hrelementsOfLtitemgt RSS
2.0].
[https://github.com/django/django/pull/13230 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/31822#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Viktor Garske | Owner: Viktor
| Garske
Type: New feature | Status: assigned
Component: contrib.syndication | Version: master
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/31822#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Viktor Garske | Owner: Viktor
| Garske
Component: contrib.syndication | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"1173db4a16bb2938ba62a6cd50372a76a7f9e05f" 1173db4a]:
{{{
#!CommitTicketReference repository=""
revision="1173db4a16bb2938ba62a6cd50372a76a7f9e05f"
Fixed #31822 -- Added support for comments URL per feed item.
The item_comments hook returns a comments URL which is then used by the
feed builder.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31822#comment:5>