[Django] #33128: Grammar Issue

Django

unread,

Sep 21, 2021, 5:12:49 PM9/21/21

to django-...@googlegroups.com

For Django 4.0, you have the following documentation. In each paragraph,
the phrase "as per the forms" needs to be changed to "as per the form's".

aseFormSet.template_name
New in Django 4.0.
The name of the template used when calling __str__ or render(). This
template renders the formsets management forms and then each form in the
formset as per the template defined by the forms template_name. This is a
proxy of as_table by default.

BaseFormSet.template_name_p
New in Django 4.0.
The name of the template used when calling as_p(). By default this is
'django/forms/formsets/p.html'. This template renders the formsets
management forms and then each form in the formset as per the forms as_p()
method.

BaseFormSet.template_name_table
New in Django 4.0.
The name of the template used when calling as_table(). By default this is
'django/forms/formsets/table.html'. This template renders the formsets
management forms and then each form in the formset as per the forms
as_table() method.

BaseFormSet.template_name_ul
New in Django 4.0.
The name of the template used when calling as_ul(). By default this is
'django/forms/formsets/ul.html'. This template renders the formsets
management forms and then each form in the formset as per the forms
as_ul() method.

--
Ticket URL: <https://code.djangoproject.com/ticket/33128>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,

Sep 21, 2021, 5:15:01 PM9/21/21

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Description changed by Matthew Pava:

Old description:

New description:

https://docs.djangoproject.com/en/dev/topics/forms/formsets/#formset-
rendering

For Django 4.0, you have the following documentation. In each paragraph,
the phrase "as per the forms" needs to be changed to ''"as per the

forms'''. (the possessive case)

BaseFormSet.template_name

New in Django 4.0.
The name of the template used when calling __str__ or render(). This
template renders the formsets management forms and then each form in the
formset as per the template defined by the forms template_name. This is a
proxy of as_table by default.

BaseFormSet.template_name_p
New in Django 4.0.
The name of the template used when calling as_p(). By default this is
'django/forms/formsets/p.html'. This template renders the formsets
management forms and then each form in the formset as per the forms as_p()
method.

BaseFormSet.template_name_table
New in Django 4.0.
The name of the template used when calling as_table(). By default this is
'django/forms/formsets/table.html'. This template renders the formsets
management forms and then each form in the formset as per the forms
as_table() method.

BaseFormSet.template_name_ul
New in Django 4.0.
The name of the template used when calling as_ul(). By default this is
'django/forms/formsets/ul.html'. This template renders the formsets
management forms and then each form in the formset as per the forms
as_ul() method.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/33128#comment:1>

Django

unread,

Sep 21, 2021, 5:15:29 PM9/21/21

to django-...@googlegroups.com

#33128: Grammar Issue
-------------------------------------+-------------------------------------
Reporter: Matthew Pava | Owner: nobody
Type: | Status: new
Cleanup/optimization |

Component: Documentation | Version: 4.0
Severity: Release blocker | Resolution:
Keywords: grammar issue | Triage Stage:
| Unreviewed

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Description changed by Matthew Pava:

Old description:

> https://docs.djangoproject.com/en/dev/topics/forms/formsets/#formset-

> rendering
>
> For Django 4.0, you have the following documentation. In each paragraph,
> the phrase "as per the forms" needs to be changed to ''"as per the

> forms'''. (the possessive case)
>
> BaseFormSet.template_name

> New in Django 4.0.
> The name of the template used when calling __str__ or render(). This
> template renders the formsets management forms and then each form in the
> formset as per the template defined by the forms template_name. This is a
> proxy of as_table by default.
>
> BaseFormSet.template_name_p
> New in Django 4.0.
> The name of the template used when calling as_p(). By default this is
> 'django/forms/formsets/p.html'. This template renders the formsets
> management forms and then each form in the formset as per the forms
> as_p() method.
>
> BaseFormSet.template_name_table
> New in Django 4.0.
> The name of the template used when calling as_table(). By default this is
> 'django/forms/formsets/table.html'. This template renders the formsets
> management forms and then each form in the formset as per the forms
> as_table() method.
>
> BaseFormSet.template_name_ul
> New in Django 4.0.
> The name of the template used when calling as_ul(). By default this is
> 'django/forms/formsets/ul.html'. This template renders the formsets
> management forms and then each form in the formset as per the forms
> as_ul() method.

New description:

https://docs.djangoproject.com/en/dev/topics/forms/formsets/#formset-
rendering

For Django 4.0, you have the following documentation. In each paragraph,

the phrase "as per the forms" needs to be changed to ''as per the forms'".
(the possessive case)

BaseFormSet.template_name

New in Django 4.0.
The name of the template used when calling __str__ or render(). This
template renders the formsets management forms and then each form in the
formset as per the template defined by the forms template_name. This is a
proxy of as_table by default.

BaseFormSet.template_name_p
New in Django 4.0.
The name of the template used when calling as_p(). By default this is
'django/forms/formsets/p.html'. This template renders the formsets
management forms and then each form in the formset as per the forms as_p()
method.

BaseFormSet.template_name_table
New in Django 4.0.
The name of the template used when calling as_table(). By default this is
'django/forms/formsets/table.html'. This template renders the formsets
management forms and then each form in the formset as per the forms
as_table() method.

BaseFormSet.template_name_ul
New in Django 4.0.
The name of the template used when calling as_ul(). By default this is
'django/forms/formsets/ul.html'. This template renders the formsets
management forms and then each form in the formset as per the forms
as_ul() method.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/33128#comment:2>

Django

unread,

Sep 21, 2021, 5:15:48 PM9/21/21

to django-...@googlegroups.com

#33128: Grammar Issue
-------------------------------------+-------------------------------------
Reporter: Matthew Pava | Owner: nobody
Type: | Status: new
Cleanup/optimization |

Component: Documentation | Version: 4.0
Severity: Release blocker | Resolution:
Keywords: grammar issue | Triage Stage:
| Unreviewed

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Description changed by Matthew Pava:

Old description:

> https://docs.djangoproject.com/en/dev/topics/forms/formsets/#formset-

> rendering
>
> For Django 4.0, you have the following documentation. In each paragraph,
> the phrase "as per the forms" needs to be changed to ''as per the

> forms'". (the possessive case)
>
> BaseFormSet.template_name

> New in Django 4.0.
> The name of the template used when calling __str__ or render(). This
> template renders the formsets management forms and then each form in the
> formset as per the template defined by the forms template_name. This is a
> proxy of as_table by default.
>
> BaseFormSet.template_name_p
> New in Django 4.0.
> The name of the template used when calling as_p(). By default this is
> 'django/forms/formsets/p.html'. This template renders the formsets
> management forms and then each form in the formset as per the forms
> as_p() method.
>
> BaseFormSet.template_name_table
> New in Django 4.0.
> The name of the template used when calling as_table(). By default this is
> 'django/forms/formsets/table.html'. This template renders the formsets
> management forms and then each form in the formset as per the forms
> as_table() method.
>
> BaseFormSet.template_name_ul
> New in Django 4.0.
> The name of the template used when calling as_ul(). By default this is
> 'django/forms/formsets/ul.html'. This template renders the formsets
> management forms and then each form in the formset as per the forms
> as_ul() method.

New description:

https://docs.djangoproject.com/en/dev/topics/forms/formsets/#formset-
rendering

For Django 4.0, you have the following documentation. In each paragraph,

the phrase "as per the forms" needs to be changed to "as per the forms'".
(the possessive case)

BaseFormSet.template_name

New in Django 4.0.
The name of the template used when calling __str__ or render(). This
template renders the formsets management forms and then each form in the
formset as per the template defined by the forms template_name. This is a
proxy of as_table by default.

BaseFormSet.template_name_p
New in Django 4.0.
The name of the template used when calling as_p(). By default this is
'django/forms/formsets/p.html'. This template renders the formsets
management forms and then each form in the formset as per the forms as_p()
method.

BaseFormSet.template_name_table
New in Django 4.0.
The name of the template used when calling as_table(). By default this is
'django/forms/formsets/table.html'. This template renders the formsets
management forms and then each form in the formset as per the forms
as_table() method.

BaseFormSet.template_name_ul
New in Django 4.0.
The name of the template used when calling as_ul(). By default this is
'django/forms/formsets/ul.html'. This template renders the formsets
management forms and then each form in the formset as per the forms
as_ul() method.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/33128#comment:3>

Django

unread,

Sep 21, 2021, 11:16:00 PM9/21/21

to django-...@googlegroups.com

#33128: Grammar Issue
-------------------------------------+-------------------------------------
Reporter: Matthew Pava | Owner: Joel
Type: | Farthing
Cleanup/optimization | Status: assigned

Component: Documentation | Version: 4.0
Severity: Release blocker | Resolution:
Keywords: grammar issue | Triage Stage:
| Unreviewed

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Joel Farthing):

* owner: nobody => Joel Farthing
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/33128#comment:4>

Django

unread,

Sep 21, 2021, 11:23:00 PM9/21/21

to django-...@googlegroups.com

#33128: Grammar Issue
-------------------------------------+-------------------------------------

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Joel Farthing):

* has_patch: 0 => 1

Comment:

The docs say to just submit a PR if it's a simple fix. As this is my first
Django contribution I figured I should walk through the ticket 'claiming'
step as well.

--
Ticket URL: <https://code.djangoproject.com/ticket/33128#comment:5>

Django

unread,

Sep 22, 2021, 5:13:18 AM9/22/21

to django-...@googlegroups.com

#33128: Grammar Issue
-------------------------------------+-------------------------------------

Keywords: grammar issue | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Carlton Gibson):

* stage: Unreviewed => Accepted

Comment:

Yes, thanks. It's difficult to parse correctly without the right
punctuation.

--
Ticket URL: <https://code.djangoproject.com/ticket/33128#comment:6>

Django

unread,

Sep 22, 2021, 5:28:54 AM9/22/21

to django-...@googlegroups.com

#33128: Grammar Issue
-------------------------------------+-------------------------------------

Keywords: grammar issue | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Carlton Gibson):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/33128#comment:7>

Django

unread,

Sep 22, 2021, 5:29:53 AM9/22/21

to django-...@googlegroups.com

#33128: Grammar Issue
-------------------------------------+-------------------------------------

Reporter: Matthew Pava | Owner: Joel
Type: | Farthing
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 4.0

Severity: Normal | Resolution:

Keywords: grammar issue | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* severity: Release blocker => Normal

--
Ticket URL: <https://code.djangoproject.com/ticket/33128#comment:8>

Django

unread,

Sep 22, 2021, 5:55:15 AM9/22/21

to django-...@googlegroups.com

#33128: Grammar Issue
-------------------------------------+-------------------------------------

Reporter: Matthew Pava | Owner: Joel
Type: | Farthing

Cleanup/optimization | Status: closed
Component: Documentation | Version: 4.0
Severity: Normal | Resolution: fixed

Keywords: grammar issue | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Carlton Gibson <carlton.gibson@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"2f144323756fc6f8517e357c540f3570356d9eba" 2f14432]:
{{{
#!CommitTicketReference repository=""
revision="2f144323756fc6f8517e357c540f3570356d9eba"
Fixed #33128 -- Corrected possessive 's usage in FormSet docs.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33128#comment:9>

Django

unread,

Sep 22, 2021, 5:57:15 AM9/22/21

to django-...@googlegroups.com

#33128: Grammar Issue
-------------------------------------+-------------------------------------

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Carlton Gibson <carlton.gibson@…>):

In [changeset:"bc0cc82101f0c484e49f49ed3808c97f7eefc44c" bc0cc82]:
{{{
#!CommitTicketReference repository=""
revision="bc0cc82101f0c484e49f49ed3808c97f7eefc44c"
[4.0.x] Fixed #33128 -- Corrected possessive 's usage in FormSet docs.

Backport of 2f144323756fc6f8517e357c540f3570356d9eba from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33128#comment:10>

Reply all

Reply to author

Forward