Re: [Django] #5797: decorator_from_middleware can cause middleware hooks to run out of correct order.

[Django]

#5797: decorator_from_middleware can cause middleware hooks to run out of correct
order.
-------------------------------------+-------------------------------------
Reporter: jdunck | Owner: nobody
Type: Bug | Status: new
Component: HTTP handling | Version: master
Severity: Normal | Resolution:
Keywords: cache middleware | Triage Stage: Accepted
decorator gzip conditional http | Needs documentation: 1
Has patch: 1 | Patch needs improvement: 0
Needs tests: 1 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by hirokiky):

* cc: hirokiky@… (added)
* needs_docs: 0 => 1
* has_patch: 0 => 1
* needs_tests: 0 => 1

Comment:

I fixed decorator_from_middleware to support multiple arguments caused by
gwilson's idea,
here this
(https://github.com/hirokiky/django/commit/2db135897f7dcc86861d4e3d6328e8d86a3ecf4c)
.

It passed the existing tests by Python2.7.1 and Python 3.3.
But, It needs more testes, and documentation.

--
Ticket URL: <https://code.djangoproject.com/ticket/5797#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#5797: decorator_from_middleware can cause middleware hooks to run out of correct
order.
-------------------------------------+-------------------------------------

Reporter: jdunck | Owner: hirokiky
Type: Bug | Status: assigned

Component: HTTP handling | Version: master
Severity: Normal | Resolution:
Keywords: cache middleware | Triage Stage: Accepted
decorator gzip conditional http | Needs documentation: 1
Has patch: 1 | Patch needs improvement: 0
Needs tests: 1 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by hirokiky):

* owner: nobody => hirokiky
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/5797#comment:8>

[Django]

#5797: decorator_from_middleware can cause middleware hooks to run out of correct
order.
-------------------------------------+-------------------------------------
Reporter: jdunck | Owner: hirokiky
Type: Bug | Status: assigned
Component: HTTP handling | Version: master
Severity: Normal | Resolution:
Keywords: cache middleware | Triage Stage: Accepted

decorator gzip conditional http | Needs documentation: 0

Has patch: 1 | Patch needs improvement: 0

Needs tests: 0 | UI/UX: 0

Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by hirokiky):

* needs_docs: 1 => 0
* needs_tests: 1 => 0

Comment:

I send the pull-request here (https://github.com/django/django/pull/659).

--
Ticket URL: <https://code.djangoproject.com/ticket/5797#comment:9>

[Django]

#5797: decorator_from_middleware can cause middleware hooks to run out of correct
order.
-------------------------------------+-------------------------------------
Reporter: jdunck | Owner:

Type: Bug | Status: new

Component: HTTP handling | Version: master
Severity: Normal | Resolution:
Keywords: cache middleware | Triage Stage: Accepted
decorator gzip conditional http | Needs documentation: 0

Has patch: 0 | Patch needs improvement: 0

Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by hirokiky):

* owner: hirokiky =>
* status: assigned => new
* has_patch: 1 => 0

Comment:

The pull-requelt doesn't work current master brunch.
(https://github.com/django/django/pull/659)

--
Ticket URL: <https://code.djangoproject.com/ticket/5797#comment:10>

[Django]

#5797: decorator_from_middleware can cause middleware hooks to run out of correct
order.
-------------------------------------+-------------------------------------
Reporter: jdunck | Owner:
Type: Bug | Status: new
Component: HTTP handling | Version: master
Severity: Normal | Resolution:
Keywords: cache middleware | Triage Stage: Accepted
decorator gzip conditional http | Needs documentation: 0

Has patch: 1 | Patch needs improvement: 1

Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by hirokiky):

* needs_better_patch: 0 => 1

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/5797#comment:11>

[Django]

#5797: decorator_from_middleware can cause middleware hooks to run out of correct
order.
-------------------------------------+-------------------------------------
Reporter: jdunck | Owner:
Type: Bug | Status: new
Component: HTTP handling | Version: master
Severity: Normal | Resolution:
Keywords: cache middleware | Triage Stage: Accepted
decorator gzip conditional http |

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by auvipy):

Replying to [comment:10 hirokiky]:

> The pull-requelt doesn't work current master brunch.
(https://github.com/django/django/pull/659)

so to make it properly need to rework based on this
https://github.com/hirokiky/django/commit/2db135897f7dcc86861d4e3d6328e8d86a3ecf4c
against master right?

--
Ticket URL: <https://code.djangoproject.com/ticket/5797#comment:12>

[Django]

#5797: decorator_from_middleware can cause middleware hooks to run out of correct
order.
-------------------------------------+-------------------------------------

Reporter: Jeremy Dunck | Owner: (none)

Type: Bug | Status: new
Component: HTTP handling | Version: master
Severity: Normal | Resolution:
Keywords: cache middleware | Triage Stage: Accepted
decorator gzip conditional http |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Herbert Fortes):

* cc: Herbert Fortes (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/5797#comment:13>