Re: [Django] #9586: Shall upload_to return an urlencoded string or not?
Django
-------------------------------------+-------------------------------------
Reporter: eibaan | Owner: nobody
Type: Bug | Status: new
Component: File | Version: 1.0
uploads/storage | Resolution:
Severity: Normal | Triage Stage: Design
Keywords: | decision needed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by anonymous):
* ui_ux: => 0
* easy: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/9586#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: eibaan | Owner: nobody
Type: Bug | Status: new
Component: File | Version: 1.0
uploads/storage | Resolution:
Severity: Normal | Triage Stage: Design
Keywords: | decision needed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by aaugustin):
Yes, the `url` method should apply `iri_to_uri`. (I haven't verified that
the issue is still valid.)
--
Ticket URL: <https://code.djangoproject.com/ticket/9586#comment:7>
Django
Reporter: eibaan | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by aaugustin):
* needs_better_patch: 0 => 1
* has_patch: 0 => 1
* needs_tests: 0 => 1
* easy: 0 => 1
* stage: Design decision needed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/9586#comment:8>
Django
--------------------------------------+------------------------------------
Type: Bug | Status: assigned
Component: File uploads/storage | Version: 1.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
* status: new => assigned
* owner: nobody => susan
--
Ticket URL: <https://code.djangoproject.com/ticket/9586#comment:9>
Django
--------------------------------------+------------------------------------
Reporter: eibaan | Owner:
Component: File uploads/storage | Version: 1.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by susan):
* owner: susan =>
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/9586#comment:10>
Django
--------------------------------------+------------------------------------
Reporter: eibaan | Owner:
Type: Bug | Status: new
Component: File uploads/storage | Version: 1.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
--------------------------------------+------------------------------------
Changes (by timo):
* easy: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/9586#comment:11>
Django
--------------------------------------+------------------------------------
Reporter: eibaan | Owner:
Type: Bug | Status: new
Component: File uploads/storage | Version: 1.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by anonymous):
Hi I just stumbled over this problem using Django 1.6.4 on windows.
Is there any idea when this bug will be fixed,
or is there a "howto" somewhere?
--
Ticket URL: <https://code.djangoproject.com/ticket/9586#comment:12>
Django
--------------------------------------+------------------------------------
Reporter: eibaan | Owner:
Type: Bug | Status: new
Component: File uploads/storage | Version: 1.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
--------------------------------------+------------------------------------
* needs_better_patch: 1 => 0
* needs_tests: 1 => 0
Comment:
Looks like this was fixed by #25905 - I cannot reproduce the original
issue. I haven't tested on Windows though.
`models.py`:
{{{
#!python
# -*- coding: utf-8 -*-
from __future__ import unicode_literals
from django.db import models
def upload_to(instance, filename):
return 'Großköln / €/{}'.format(filename)
class FileModel(models.Model):
file = models.FileField(upload_to=upload_to)
}}}
`admin.py`
{{{
#!python
from django.contrib import admin
from .models import FileModel
admin.site.register(FileModel)
}}}
and the rest is the standard media/staticfiles settings/urls.
The url presented to me in the admin:
`<a href="/media/Gro%C3%9Fk%C3%B6ln%20/%20%E2%82%AC/mail.txt">Großköln /
€/mail.txt</a>`
which is properly escaped and served by django.
--
Ticket URL: <https://code.djangoproject.com/ticket/9586#comment:13>
Django
--------------------------------------+------------------------------------
Reporter: eibaan | Owner:
Component: File uploads/storage | Version: 1.0
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by sergei-maertens):
* status: new => closed
* resolution: => fixed
--
Ticket URL: <https://code.djangoproject.com/ticket/9586#comment:14>