Re: [Django] #12405: django.contrib.auth.views.logout() should support LOGOUT_REDIRECT_URL
Django
-------------------------------------+-------------------------------------
Reporter: cmwslw | Owner: bigkevmcd
Type: New feature | Status: assigned
Component: contrib.auth | Version: 1.1
Severity: Normal | Resolution:
Keywords: logout | Triage Stage: Accepted
LOGOUT_REDIRECT_URL | Needs documentation: 1
Has patch: 0 | Patch needs improvement: 0
Needs tests: 1 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by bigkevmcd):
* owner: dloewenherz => bigkevmcd
--
Ticket URL: <https://code.djangoproject.com/ticket/12405#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: cmwslw | Owner: bigkevmcd
Type: New feature | Status: assigned
Component: contrib.auth | Version: 1.1
Severity: Normal | Resolution:
Keywords: logout | Triage Stage: Accepted
LOGOUT_REDIRECT_URL | Needs documentation: 1
Has patch: 0 | Patch needs improvement: 0
Needs tests: 1 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by anonymous):
So? What's the status?
--
Ticket URL: <https://code.djangoproject.com/ticket/12405#comment:12>
Django
-------------------------------------+-------------------------------------
Reporter: cmwslw | Owner:
Component: contrib.auth | Version: 1.1
Severity: Normal | Resolution:
Keywords: logout | Triage Stage: Accepted
LOGOUT_REDIRECT_URL | Needs documentation: 1
Has patch: 0 | Patch needs improvement: 0
Needs tests: 1 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* status: assigned => new
* owner: bigkevmcd =>
--
Ticket URL: <https://code.djangoproject.com/ticket/12405#comment:13>
Django
-------------------------------------+-------------------------------------
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: logout | Triage Stage: Accepted
LOGOUT_REDIRECT_URL |
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by cbarcenas):
* owner: => cbarcenas
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/12405#comment:14>
Django
-------------------------------------+-------------------------------------
Reporter: cmwslw | Owner: cbarcenas
Type: New feature | Status: assigned
Component: contrib.auth | Version: 1.1
Severity: Normal | Resolution:
Keywords: logout | Triage Stage: Accepted
LOGOUT_REDIRECT_URL |
Has patch: 0 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by cbarcenas):
Picking this one up as my first contribution to Django :) I don't
anticipate this taking more than a few lines of code and a test or two.
--
Ticket URL: <https://code.djangoproject.com/ticket/12405#comment:15>
Django
-------------------------------------+-------------------------------------
Reporter: cmwslw | Owner: cbarcenas
Type: New feature | Status: assigned
Component: contrib.auth | Version: 1.1
Severity: Normal | Resolution:
Keywords: logout | Triage Stage: Accepted
LOGOUT_REDIRECT_URL |
Has patch: 0 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by hobarrera):
I've implemented a PR for this, based on changes that implemented this on
a specific project:
https://github.com/django/django/pull/5193
Let me know if there's anything that need tweaking.
--
Ticket URL: <https://code.djangoproject.com/ticket/12405#comment:16>
Django
-------------------------------------+-------------------------------------
Reporter: cmwslw | Owner: cbarcenas
Type: New feature | Status: assigned
Component: contrib.auth | Version: 1.1
Severity: Normal | Resolution:
Keywords: logout | Triage Stage: Accepted
LOGOUT_REDIRECT_URL |
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_docs: 1 => 0
* has_patch: 0 => 1
Comment:
Tests are missing. Please uncheck "Needs tests" on the ticket when you
update it so the ticket appears in the review queue, thanks!
--
Ticket URL: <https://code.djangoproject.com/ticket/12405#comment:17>
Django
-------------------------------------+-------------------------------------
Type: New feature | Status: assigned
Component: contrib.auth | Version: 1.1
Severity: Normal | Resolution:
Keywords: logout | Triage Stage: Accepted
LOGOUT_REDIRECT_URL |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: cbarcenas => hobarrera
* needs_tests: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/12405#comment:18>
Django
-------------------------------------+-------------------------------------
Reporter: cmwslw | Owner: hobarrera
Component: contrib.auth | Version: 1.1
Severity: Normal | Resolution: fixed
Keywords: logout | Triage Stage: Accepted
LOGOUT_REDIRECT_URL |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"dcee1dfc798bbf4602a35fb73f6acade9f5fd630" dcee1dfc]:
{{{
#!CommitTicketReference repository=""
revision="dcee1dfc798bbf4602a35fb73f6acade9f5fd630"
Fixed #12405 -- Added LOGOUT_REDIRECT_URL setting.
After a user logs out via auth.views.logout(), they're redirected
to LOGOUT_REDIRECT_URL if no `next_page` argument is provided.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/12405#comment:19>