[Django] #24784: Admin interface ForeignKey field select widget partially hidden in Firefox
Django
-------------------------------+--------------------
Reporter: hobbsd | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------
This problem appeared in Django 1.8 (it remains in 1.8.1) -- it's fine in
1.7.8. The size of the "related-widget-wrapper" is too narrow, and the
select widget overflow gets hidden. This is in Firefox 37 -- it doesn't
get hidden in Chrome (I didn't try other browsers), but I think the layout
of objects within the wrapper did change in Chrome.
--
Ticket URL: <https://code.djangoproject.com/ticket/24784>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: hobbsd | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.8
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Easy pickings: 0
UI/UX: 1 |
Changes (by hobbsd):
* Attachment "Screen-2015-05-11_13-47.png" added.
Django 1.7.8 in Firefox 37
Django
Reporter: hobbsd | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.8
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Easy pickings: 0
UI/UX: 1 |
Changes (by hobbsd):
* Attachment "Screen-2015-05-11_13-49.png" added.
Django 1.8.1 in Firefox 37
Django
Reporter: hobbsd | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.8
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Easy pickings: 0
UI/UX: 1 |
Changes (by hobbsd):
* Attachment "Screen-2015-05-11_13-50.png" added.
Django 1.8.1 related-widget-wrapper too narrow
Django
Reporter: hobbsd | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.8
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by hobbsd):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
It looks like it only happens when the ForeignKey field is in a row with
other fields.
--
Ticket URL: <https://code.djangoproject.com/ticket/24784#comment:1>
Django
Reporter: hobbsd | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.8
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Comment (by timgraham):
How do you make the `ForeignKey` field appear in a row with other fields?
--
Ticket URL: <https://code.djangoproject.com/ticket/24784#comment:2>
Django
Reporter: hobbsd | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.8
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Comment (by hobbsd):
Replying to [comment:2 timgraham]:
> How do you make the `ForeignKey` field appear in a row with other
fields?
In admin.py, for example:
{{{#!python
fieldsets = (
(None, {'fields': (('status', 'created', 'modified'),)}),
)
}}}
And 'status' is a `ForeignKey`.
--
Ticket URL: <https://code.djangoproject.com/ticket/24784#comment:3>
Django
Reporter: hobbsd | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.8
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Comment (by timgraham):
I tried to reproduce using the tutorial, but the "Poll" selector appears
fine. Does this code reproduce the problem for you? Tested on Ubuntu 14.04
and Firefox 38.
{{{
class ChoiceAdmin(admin.ModelAdmin):
fieldsets = [
(None, {'fields': ['poll', 'votes']}),
]
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24784#comment:4>
Django
Reporter: hobbsd | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.8
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Comment (by hobbsd):
Replying to [comment:4 timgraham]:
> I tried to reproduce using the tutorial, but the "Poll" selector appears
fine. Does this code reproduce the problem for you? Tested on Ubuntu 14.04
and Firefox 38.
> {{{
> class ChoiceAdmin(admin.ModelAdmin):
> fieldsets = [
> (None, {'fields': ['poll', 'votes']}),
> ]
> }}}
Using the tutorial I was able to reproduce with:
{{{
class ChoiceAdmin(admin.ModelAdmin):
fieldsets = [
(None, {'fields': [('question', 'votes')]}),
]
}}}
Note the parens around the two fields to put them on the same line. This
is on Windows 7 w/ Firefox 37.
--
Ticket URL: <https://code.djangoproject.com/ticket/24784#comment:5>
Django
Reporter: hobbsd | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.8
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by timgraham):
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/24784#comment:6>
Django
Reporter: hobbsd | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.8
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by timgraham):
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/4671 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/24784#comment:7>
Django
Reporter: hobbsd | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.8
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"fb94e7b8cf8f68629b51a4d4f2c37400ef1c7469" fb94e7b]:
{{{
#!CommitTicketReference repository=""
revision="fb94e7b8cf8f68629b51a4d4f2c37400ef1c7469"
Fixed #24784 -- Fixed visibility regression in admin's FK widget.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24784#comment:8>
Django
Reporter: hobbsd | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.8
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Comment (by Tim Graham <timograham@…>):
In [changeset:"aeafdf9398edb8a9fe34e10af10f98ae567a97db" aeafdf9]:
{{{
#!CommitTicketReference repository=""
revision="aeafdf9398edb8a9fe34e10af10f98ae567a97db"
[1.8.x] Fixed #24784 -- Fixed visibility regression in admin's FK widget.
Backport of fb94e7b8cf8f68629b51a4d4f2c37400ef1c7469 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24784#comment:9>