[Django] #29048: Add **extra_context arg to as_vendor methods in database functions
Django
-------------------------------------+-------------------------------------
Reporter: Matthew | Owner: nobody
Pava |
Type: | Status: new
Cleanup/optimization |
Component: Database | Version: master
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
`Func` inherits from `SQLiteNumericMixin`, which added an extra argument
to `as_sqlite`: `**extra_context`. Based on feedback from other
developers, it seems we should add this argument to each `as_vendor`
method.
--
Ticket URL: <https://code.djangoproject.com/ticket/29048>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):
* easy: 1 => 0
Comment:
Is there a concrete problem? It's unclear what "Based on feedback from
other developers" refers to.
--
Ticket URL: <https://code.djangoproject.com/ticket/29048#comment:1>
Django
-------------------------------------+-------------------------------------
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Old description:
> `Func` inherits from `SQLiteNumericMixin`, which added an extra argument
> to `as_sqlite`: `**extra_context`. Based on feedback from other
> developers, it seems we should add this argument to each `as_vendor`
> method.
New description:
`Func` inherits from `SQLiteNumericMixin`, which added an extra argument
to `as_sqlite`: `**extra_context`. PyCharm flags the database functions
that inherit from `Func` because their `as_sqlite` methods do not have
that extra argument.
--
Comment (by Matthew Pava):
I updated the description to describe the problem in better detail.
When I was working on
[https://github.com/django/django/pull/9583/files/4b61d2bc73641edbe303ecdbcc8f810db795f1b3
#diff-bda8c5979f2cb4b5bf2d3f87f507363f PR 9583], a contributor made this
comment when I had unintentionally made the changes to other classes not
related to that PR:
> I've also noticed a warning in Pycharm that the signature of as_sqlite
and as_oracle doesn't match the superclass. I'd guess it's better to deal
with this in a different PR.
I assumed that the contributor was speaking on behalf of "other
developers."
--
Ticket URL: <https://code.djangoproject.com/ticket/29048#comment:2>
Django
-------------------------------------+-------------------------------------
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):
* stage: Unreviewed => Accepted
Comment:
But there's no concrete issue, correct? I suppose we can change those
signatures, even if it's just fix the PyCharm warnings.
--
Ticket URL: <https://code.djangoproject.com/ticket/29048#comment:3>
Django
-------------------------------------+-------------------------------------
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Matthew Pava):
Correct, Tim.
--
Ticket URL: <https://code.djangoproject.com/ticket/29048#comment:4>
Django
-------------------------------------+-------------------------------------
Type: | Saxena
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* owner: nobody => Priyansh Saxena
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/29048#comment:5>
Django
-------------------------------------+-------------------------------------
Type: | Saxena
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Priyansh Saxena):
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/9673 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/29048#comment:6>
Django
-------------------------------------+-------------------------------------
Type: | Saxena
Cleanup/optimization | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/29048#comment:7>
Django
-------------------------------------+-------------------------------------
Type: | Saxena
Component: Database layer | Version: master
(models, ORM) |
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"83b04d4f88dd65ae630a45385de34e275899dc41" 83b04d4]:
{{{
#!CommitTicketReference repository=""
revision="83b04d4f88dd65ae630a45385de34e275899dc41"
Fixed #29048 -- Added **extra_context to database function as_vendor()
methods.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29048#comment:8>