[Django] #31645: Models have changes red alert message should say which apps/models
Django
-------------------------------------------+------------------------
Reporter: John Vandenberg | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 3.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+------------------------
When running 'migrate', the message appearing when there are missing
migrations should say which app/model it detected has missing migrations.
The message is currently:
Your models have changes that are not yet reflected in a migration, and
so won't be applied.
Run 'manage.py makemigrations' to make new migrations, and then re-run
'manage.py migrate' to apply them.
--
Ticket URL: <https://code.djangoproject.com/ticket/31645>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: John Vandenberg | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 3.0
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Keryn Knight):
* cc: Keryn Knight (added)
* stage: Unreviewed => Accepted
Comment:
Tentatively marking this as accepted (if it's not too invasive to surface)
because there's prior acceptance for similar in #25855.
--
Ticket URL: <https://code.djangoproject.com/ticket/31645#comment:1>
Django
Reporter: John Vandenberg | Owner: nobody
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Chinmoy):
Hey I'm a beginner in opensource and would like to work on this issue. May
I claim the ticket ?
--
Ticket URL: <https://code.djangoproject.com/ticket/31645#comment:3>
Django
Reporter: John Vandenberg | Owner: nobody
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by felixxm):
Feel-free.
--
Ticket URL: <https://code.djangoproject.com/ticket/31645#comment:4>
Django
Reporter: John Vandenberg | Owner: Chinmoy
Type: Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Chinmoy):
* owner: nobody => Chinmoy
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/31645#comment:5>
Django
Reporter: John Vandenberg | Owner: Chinmoy
Type: Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Chinmoy):
What would be an appropriate message here? Will simply printing out the
**changes** dict work?
--
Ticket URL: <https://code.djangoproject.com/ticket/31645#comment:6>
Django
Reporter: John Vandenberg | Owner: Chinmoy
Type: Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Chinmoy):
I think a message similar to that given by **makemigrations --dry-run**
would be good enough?
--
Ticket URL: <https://code.djangoproject.com/ticket/31645#comment:7>
Django
Reporter: John Vandenberg | Owner: Chinmoy
Type: Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Chinmoy):
* Attachment "mod_out.png" added.
Test output of pending migrations
Django
Reporter: John Vandenberg | Owner: Chinmoy
Type: Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Chinmoy):
Will any tests be necessary for this? If yes, what should it test?
--
Ticket URL: <https://code.djangoproject.com/ticket/31645#comment:8>
Django
Reporter: John Vandenberg | Owner: Chinmoy
Type: Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Chinmoy):
Submitted a patch [https://github.com/django/django/pull/13027]
--
Ticket URL: <https://code.djangoproject.com/ticket/31645#comment:9>
Django
Reporter: John Vandenberg | Owner: Chinmoy
Type: Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Chinmoy):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/31645#comment:10>
Django
Reporter: John Vandenberg | Owner: Chinmoy
Type: Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Chinmoy):
Patch waiting for review. Can someone please review it?
--
Ticket URL: <https://code.djangoproject.com/ticket/31645#comment:11>
Django
Reporter: John Vandenberg | Owner: Chinmoy
Type: Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* needs_better_patch: 0 => 1
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/31645#comment:12>
Django
Reporter: John Vandenberg | Owner: Chinmoy
Cleanup/optimization |
Component: Migrations | Version: master
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* needs_better_patch: 1 => 0
* needs_tests: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/31645#comment:13>
Django
Reporter: John Vandenberg | Owner: Chinmoy
Cleanup/optimization |
Component: Migrations | Version: master
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"2928019e0ccd8e9c7d3a3fba7722a7af87018e5d" 2928019e]:
{{{
#!CommitTicketReference repository=""
revision="2928019e0ccd8e9c7d3a3fba7722a7af87018e5d"
Fixed #31645 -- Enhanced the migration warning for migrate commmand.
Added the list of apps with changes not reflected in migrations.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31645#comment:14>