[Django] #21051: Move cookie settings from standalone values to dictionaries

13 views
Skip to first unread message

Django

unread,
Sep 6, 2013, 7:22:25 AM9/6/13
to django-...@googlegroups.com
#21051: Move cookie settings from standalone values to dictionaries
-------------------------------------+-------------------------------------
Reporter: ramiro | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Core | Keywords: cookie cookis csrf
(Other) | sesssion language
Severity: Normal | Has patch: 1
Triage Stage: | Needs tests: 0
Unreviewed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
This could help with #15318 and other efforts to expand configurability of
existing cookie-related settings.

See https://github.com/django/django/pull/1554 for the patch.

--
Ticket URL: <https://code.djangoproject.com/ticket/21051>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 9, 2013, 10:59:01 AM9/9/13
to django-...@googlegroups.com
#21051: Move cookie settings from standalone values to dictionaries
-------------------------------------+-------------------------------------
Reporter: ramiro | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Core (Other) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: cookie cookis csrf | Needs documentation: 0
sesssion language | Patch needs improvement: 0
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by timo):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/21051#comment:1>

Django

unread,
Oct 2, 2013, 11:35:52 AM10/2/13
to django-...@googlegroups.com
#21051: Move cookie settings from standalone values to dictionaries
-------------------------------------+-------------------------------------
Reporter: ramiro | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Core (Other) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: cookie cookis csrf | Needs documentation: 0
sesssion language | Patch needs improvement: 1

Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by timo):

* needs_better_patch: 0 => 1


Comment:

After discussion with Ramiro on IRC, we're not sure if we should move
forward with this. Using a dictionary has the problem that default
settings from `django/conf/global_settings.py` would be lost if only
overriding part of the `SESSION_COOKIE` dictionary. I proposed the
possibility of adding a shim to the settings setter to merge the two
dictionaries, but I'm not sure if this is feasible or worth it.

Marking as "patch needs improvement", but leaving it up to Ramiro as to
whether we should move forward or won't fix.

--
Ticket URL: <https://code.djangoproject.com/ticket/21051#comment:2>

Django

unread,
Feb 8, 2014, 8:21:17 AM2/8/14
to django-...@googlegroups.com
#21051: Move cookie settings from standalone values to dictionaries
-------------------------------------+-------------------------------------
Reporter: ramiro | Owner: nobody
Type: | Status: closed
Cleanup/optimization | Version: master
Component: Core (Other) | Resolution: wontfix

Severity: Normal | Triage Stage: Accepted
Keywords: cookie cookis csrf | Needs documentation: 0
sesssion language | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by ramiro):

* status: new => closed
* resolution: => wontfix


Comment:

The described limitations seem unlikely fixable with urrent implementation
of settings infrastructure. Closing for now.

--
Ticket URL: <https://code.djangoproject.com/ticket/21051#comment:3>

Reply all
Reply to author
Forward
0 new messages