[Django] #21516: Update the import path for the FormSet classes and factories in documentation.
Django
documentation.
--------------------------------------+--------------------
Reporter: loic84 | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
Since #21489, FormSet classes and factories are exposed directly on the
`django.forms` package.
Examples in the docs should be updated to reflect this change at some
point. The docs update is delayed for a couple of releases to help people
who misuse the dev docs with an earlier version of Django so they don't
get confusing import errors.
The original ticket (#21489) has a tentative patch and discussions
relevant to this ticket.
--
Ticket URL: <https://code.djangoproject.com/ticket/21516>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
documentation.
Reporter: loic84 | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Documentation | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Someday/Maybe
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by loic84):
* needs_better_patch: => 0
* stage: Unreviewed => Someday/Maybe
* needs_tests: => 0
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/21516#comment:1>
Django
documentation.
Reporter: loic84 | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
--------------------------------------+------------------------------------
Changes (by timgraham):
* easy: 0 => 1
* stage: Someday/Maybe => Accepted
Comment:
This change was made in Django 1.7 and all older versions are now
unsupported so it seems like a good time to make the change. See
1c7a83ee8e3da431d9d21dae42da8f1f89973f7c for the functions and classes to
update.
--
Ticket URL: <https://code.djangoproject.com/ticket/21516#comment:2>
Django
documentation.
Reporter: loic84 | Owner: bxm156
Type: Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
* status: new => assigned
* owner: nobody => bxm156
--
Ticket URL: <https://code.djangoproject.com/ticket/21516#comment:3>
Django
documentation.
Reporter: loic84 | Owner: bxm156
Type: Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by bxm156):
This is my first ticket / contribution to the Django project.
I have created a topic branch at:
https://github.com/bxm156/django/tree/ticket_21516
Commit:
https://github.com/bxm156/django/commit/9c117b9bd62ea090f1d8b4d7fb7345ebaaf9e836
Ran make html in docs locally, the build succeeded.
--
Ticket URL: <https://code.djangoproject.com/ticket/21516#comment:4>
Django
documentation.
Reporter: loic84 | Owner: bxm156
Type: Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/21516#comment:5>
Django
documentation.
Reporter: loic84 | Owner: bxm156
Type: Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/21516#comment:6>
Django
documentation.
Reporter: loic84 | Owner: bxm156
Type: Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by bxm156):
I have updated my changes to reflect timgraham's feedback.
https://github.com/django/django/pull/5492
--
Ticket URL: <https://code.djangoproject.com/ticket/21516#comment:7>
Django
documentation.
Reporter: loic84 | Owner: bxm156
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"455034d4df048010de4ae0a9a2392b70d1463c61" 455034d4]:
{{{
#!CommitTicketReference repository=""
revision="455034d4df048010de4ae0a9a2392b70d1463c61"
Fixed #21516 -- Updated imports paths for some formset functions/classes.
Since refs #21489, FormSet classes and factories are exposed on the
django.forms package.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/21516#comment:8>
Django
documentation.
Reporter: loic84 | Owner: bxm156
Type: Cleanup/optimization | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"44f177b5cdab82ffefa81abd3e9c2a13aaab256f" 44f177b5]:
{{{
#!CommitTicketReference repository=""
revision="44f177b5cdab82ffefa81abd3e9c2a13aaab256f"
[1.9.x] Fixed #21516 -- Updated imports paths for some formset
functions/classes.
Since refs #21489, FormSet classes and factories are exposed on the
django.forms package.
Backport of 455034d4df048010de4ae0a9a2392b70d1463c61 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/21516#comment:9>
Django
documentation.
Reporter: loic84 | Owner: bxm156
Type: Cleanup/optimization | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"42f254674243928a563364389906a00303cc9a56" 42f25467]:
{{{
#!CommitTicketReference repository=""
revision="42f254674243928a563364389906a00303cc9a56"
[1.8.x] Fixed #21516 -- Updated imports paths for some formset
functions/classes.
Since refs #21489, FormSet classes and factories are exposed on the
django.forms package.
Backport of 455034d4df048010de4ae0a9a2392b70d1463c61 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/21516#comment:10>