[Django] #28407: add db column comments to models Field comment_note
Django
-------------------------------------+-------------------------------------
Reporter: 007gzs | Owner: nobody
Type: New | Status: new
feature |
Component: Database | Version: 1.11
layer (models, ORM) |
Severity: Normal | Keywords: db comment
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
when use inspectdb make model from db.
the db column is created by dba, not developer .
so db column comments set to models Field is helpful for developer.
like
{{{
field = models.IntegerField(blank=True, null=True) #comments in db
}}}
[https://github.com/django/django/pull/8738]
--
Ticket URL: <https://code.djangoproject.com/ticket/28407>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: 007gzs | Owner: nobody
Component: Database layer | Version: 1.11
(models, ORM) |
Severity: Normal | Resolution:
Keywords: db comment | Triage Stage:
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Old description:
> when use inspectdb make model from db.
> the db column is created by dba, not developer .
> so db column comments set to models Field is helpful for developer.
> like
> {{{
> field = models.IntegerField(blank=True, null=True) #comments in db
> }}}
> [https://github.com/django/django/pull/8738]
New description:
when use inspectdb make model from db.
the db column is created by dba, not developer .
so db column comments set to models Field is helpful for developer.
like
{{{
field = models.IntegerField(blank=True, null=True) #comments in db
}}}
[https://github.com/django/django/pull/8770]
--
--
Ticket URL: <https://code.djangoproject.com/ticket/28407#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: 007gzs | Owner: nobody
Component: Database layer | Version: 1.11
(models, ORM) |
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
* stage: Unreviewed => Accepted
* needs_tests: 0 => 1
Comment:
I think the comment should be prefixed with something like `Column
comment: `. Also tests are required.
--
Ticket URL: <https://code.djangoproject.com/ticket/28407#comment:2>
Django
Reporter: 007gzs | Owner: nobody
Component: Database layer | Version: 1.11
(models, ORM) |
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by 007gzs):
sorry i donot know how can i add a db with comment in tests.
--
Ticket URL: <https://code.djangoproject.com/ticket/28407#comment:3>
Django
Reporter: 007gzs | Owner: nobody
Component: Database layer | Version: 1.11
(models, ORM) |
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham):
I think it would involve something like adding a
`BaseDatabaseSchemaEditor.sql_create_column_comment` attribute with the
SQL for creating a column comment. Then the test can use that.
--
Ticket URL: <https://code.djangoproject.com/ticket/28407#comment:4>
Django
Reporter: 007gzs | Owner: nobody
Component: Database layer | Version: 1.11
(models, ORM) |
Keywords: db comment | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => duplicate
Comment:
Adding column comments as a model field option is accepted in #18468.
--
Ticket URL: <https://code.djangoproject.com/ticket/28407#comment:5>