[Django] #16922: Add a template-based form rendering system
Django
--------------------------------+------------------------------------
Reporter: carljm | Owner: nobody
Type: New feature | Status: new
Milestone: | Component: Forms
Version: SVN | Severity: Normal
Keywords: form-rendering | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+------------------------------------
This was accepted as a GSoC project for 2011, and the work was done by
Gregor Müllegger. There were [http://groups.google.com/group/django-
developers/browse_frm/thread/3791152616fd95ae/6bbb2bf4d2f6752c?lnk=gst&q=form+rendering+api#6bbb2bf4d2f6752c
extensive discussions] on the django-developers mailing list about the
API.
This ticket is to track the remaining work to get this template-based form
rendering API into trunk. The most recent code is at
https://github.com/carljm/django/compare/master...soc2011%2Fform-rendering
- that branch also contains code for #15667 and #16921.
I expect that of those three tickets, #16921 can be merged first, then
#15667, and this one last.
The primary issue that still needs to be resolved on this ticket, as well
as #15667, is performance. https://github.com/carljm/formrenderbench can
help with setting up benchmarks.
--
Ticket URL: <https://code.djangoproject.com/ticket/16922>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Type: New feature | Status: new
Milestone: | Component: Forms
Version: SVN | Severity: Normal
Triage Stage: Accepted | Has patch: 1
UI/UX: 0 |
---------------------------------------+--------------------------------
Changes (by carljm):
* needs_better_patch: 0 => 1
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/16922#comment:1>
Django
--------------------------------+------------------------------------
Reporter: carljm | Owner: nobody
Type: New feature | Status: new
Severity: Normal | Resolution:
Keywords: form-rendering | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------+------------------------------------
Comment (by timo):
Carl, it looks like the branch linked above doesn't exist anymore? Do we
need to start from scratch on this?
--
Ticket URL: <https://code.djangoproject.com/ticket/16922#comment:2>
Django
--------------------------------+------------------------------------
Reporter: carljm | Owner: nobody
Type: New feature | Status: new
Severity: Normal | Resolution:
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------+------------------------------------
Comment (by carljm):
Hi Tim, a few thoughts:
1. The code that was in that GSoC branch was eventually merged into
[https://github.com/gregmuellegger/django-floppyforms django-floppyforms]
and has seen updates there since, so I think it would be best to approach
this in terms of a new Django branch copying/merging the desired code from
floppyforms.
2. I think that #15667 (rendering widgets via templates) alone addresses
90+% of the issues people have with customizing markup in Django forms. I
think that ticket is much higher priority than this one, presuming the
performance issues can be addressed, or the performance cost is deemed
acceptable.
3. Once we have #15667, there are two additional steps that could be taken
to resolve this ticket: either a) a straightforward port of the existing
`.as_ul()` and `.as_p()` methods to render via an overridable template
instead of by constructing HTML in Python, or b) a full integration of the
extensively customizable form-layouts system that Gregor built for GSoC.
To be honest, I am not sure the latter needs to be in Django, I think it
works just fine as a third-party add-on (at least until/unless that third-
party add-on proves itself as a de facto necessity a la South, which I
don't think it has done yet). So I would be in favor of limiting the scope
of this ticket to (a), and only even worrying about that once #15667 is
fixed.
--
Ticket URL: <https://code.djangoproject.com/ticket/16922#comment:3>
Django
--------------------------------+------------------------------------
Type: New feature | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------+------------------------------------
* status: new => assigned
* owner: nobody => auvipy
--
Ticket URL: <https://code.djangoproject.com/ticket/16922#comment:4>
Django
--------------------------------+------------------------------------
Reporter: carljm | Owner:
Severity: Normal | Resolution:
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------+------------------------------------
* owner: auvipy =>
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/16922#comment:5>
Django
--------------------------------+------------------------------------
Type: New feature | Status: new
Severity: Normal | Resolution:
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------+------------------------------------
Comment (by Asif Saifuddin Auvi):
As template based widget rendering is now supported, what need to be done
to complete this ticket? adjust code from floppy forms?
--
Ticket URL: <https://code.djangoproject.com/ticket/16922#comment:4>
Django
--------------------------------+------------------------------------
Type: New feature | Status: closed
Component: Forms | Version: master
Severity: Normal | Resolution: fixed
Keywords: form-rendering | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------+------------------------------------
* status: new => closed
* resolution: => fixed
--
Ticket URL: <https://code.djangoproject.com/ticket/16922#comment:5>