[Django] #27270: A form may include HTML attributes such as maxlength

36 views
Skip to first unread message

Django

unread,
Sep 25, 2016, 9:06:59 AM9/25/16
to django-...@googlegroups.com
#27270: A form may include HTML attributes such as maxlength
-------------------------------+---------------------
Reporter: Kifsif | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 1.10
Severity: Normal | Keywords: formset
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+---------------------
The documentation reads: "Just like when using a normal Form, each form in
the formset may include HTML attributes such as maxlength for browser
validation." (https://docs.djangoproject.com/en/1.10/topics/forms/formsets
/#formset-validation)

NB: **form** may include HTML attributes such as maxlength.

What astonishes me: this is not the form that may include maxlength. This
is a **field in Django and input tag in HTML**. Well, a form can contain
maxlength neither in Django nor in HTML as far as I know.


Example:

{{{
class ArticleForm(forms.Form):
title = forms.CharField(max_length=5)
}}}

Which results in:


{{{
<table>
<tr>
<th>
<label for="id_form-0-title">Title:</label>
</th>
<td>
<input id="id_form-0-title" maxlength="5" name="form-0-title"
type="text" value="Test" />
</td>
</tr>
</table>
}}}


Offered wording: Just like when using a normal Form, **each form field in
each form in the formset** may include HTML attributes such as maxlength
for browser validation.

--
Ticket URL: <https://code.djangoproject.com/ticket/27270>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 25, 2016, 9:08:51 AM9/25/16
to django-...@googlegroups.com
#27270: A form may include HTML attributes such as maxlength
-------------------------------------+-------------------------------------
Reporter: Kifsif | Owner: Kifsif
Type: | Status: assigned
Cleanup/optimization |
Component: Documentation | Version: 1.10
Severity: Normal | Resolution:

Keywords: formset | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Kifsif):

* status: new => assigned
* needs_better_patch: => 0
* needs_tests: => 0
* owner: nobody => Kifsif
* needs_docs: => 0
* type: Uncategorized => Cleanup/optimization


--
Ticket URL: <https://code.djangoproject.com/ticket/27270#comment:1>

Django

unread,
Sep 25, 2016, 9:10:20 AM9/25/16
to django-...@googlegroups.com
#27270: A form may include HTML attributes such as maxlength
-------------------------------------+-------------------------------------
Reporter: Kifsif | Owner: (none)
Type: | Status: new
Cleanup/optimization |
Component: Documentation | Version: 1.10
Severity: Normal | Resolution:

Keywords: formset | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Kifsif):

* owner: Kifsif => (none)
* status: assigned => new


--
Ticket URL: <https://code.djangoproject.com/ticket/27270#comment:2>

Django

unread,
Sep 25, 2016, 3:40:17 PM9/25/16
to django-...@googlegroups.com
#27270: A form may include HTML attributes such as maxlength
-------------------------------------+-------------------------------------
Reporter: Kifsif | Owner: (none)
Type: | Status: new
Cleanup/optimization |
Component: Documentation | Version: 1.10
Severity: Normal | Resolution:

Keywords: formset | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Emett Speer):

This seems like a good update to me. It does make the wording on this much
more clear then it currently is.

--
Ticket URL: <https://code.djangoproject.com/ticket/27270#comment:3>

Django

unread,
Sep 26, 2016, 9:54:43 AM9/26/16
to django-...@googlegroups.com
#27270: Clarify wording of "A form may include HTML attributes such as maxlength"
-------------------------------------+-------------------------------------
Reporter: Kifsif | Owner: Tim
Type: | Graham
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.10
Severity: Normal | Resolution:
Keywords: formset | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* owner: (none) => Tim Graham


* status: new => assigned

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/27270#comment:4>

Django

unread,
Sep 26, 2016, 9:55:34 AM9/26/16
to django-...@googlegroups.com
#27270: Clarify wording of "A form may include HTML attributes such as maxlength"
-------------------------------------+-------------------------------------
Reporter: Kifsif | Owner: Tim
Type: | Graham
Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.10
Severity: Normal | Resolution: fixed

Keywords: formset | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"dec77af525268a02bf964f498fefc1c27b4ebbe5" dec77af5]:
{{{
#!CommitTicketReference repository=""
revision="dec77af525268a02bf964f498fefc1c27b4ebbe5"
[1.10.x] Fixed #27270 -- Clarified a paragraph in
docs/topics/forms/formsets.txt.

Thanks Kifsif for the suggestion.

Backport of 8110673aafd48e9345c17458638c10fb12ab4f2a from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27270#comment:5>

Django

unread,
Sep 26, 2016, 9:55:34 AM9/26/16
to django-...@googlegroups.com
#27270: Clarify wording of "A form may include HTML attributes such as maxlength"
-------------------------------------+-------------------------------------
Reporter: Kifsif | Owner: Tim
Type: | Graham
Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.10

Severity: Normal | Resolution: fixed
Keywords: formset | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"8110673aafd48e9345c17458638c10fb12ab4f2a" 8110673]:
{{{
#!CommitTicketReference repository=""
revision="8110673aafd48e9345c17458638c10fb12ab4f2a"


Fixed #27270 -- Clarified a paragraph in docs/topics/forms/formsets.txt.

Thanks Kifsif for the suggestion.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27270#comment:6>

Reply all
Reply to author
Forward
0 new messages