[Django] #27505: Error messages customization and internationalization in Paginator class
Django
------------------------------------------------+------------------------
Reporter: Anton Bazhanov | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
There is no ability to change error messages raised by
Paginator.validate_number method.
--
Ticket URL: <https://code.djangoproject.com/ticket/27505>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Anton Bazhanov | Owner: Anton
Type: | Bazhanov
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: 1.10
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Anton Bazhanov):
* status: new => assigned
* owner: nobody => Anton Bazhanov
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:1>
Django
Reporter: Anton Bazhanov | Owner: Anton
Type: | Bazhanov
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Anton Bazhanov):
I created a PR https://github.com/django/django/pull/7578
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:2>
Django
Reporter: Anton Bazhanov | Owner: Anton
Type: | Bazhanov
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz):
* has_patch: 0 => 1
* version: 1.10 => master
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:3>
Django
Reporter: Anton Bazhanov | Owner: Anton
Type: | Bazhanov
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:4>
Django
Reporter: Anton Bazhanov | Owner: Anton
Type: | Bazhanov
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"e690eb405f09a9e58b9d95ae98991352602635d6" e690eb40]:
{{{
#!CommitTicketReference repository=""
revision="e690eb405f09a9e58b9d95ae98991352602635d6"
Refs #27505 -- Made Paginator's exception messsages translatable.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:5>
Django
Reporter: Anton Bazhanov | Owner: Anton
Type: | Bazhanov
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* needs_better_patch: 1 => 0
* has_patch: 1 => 0
Comment:
Strings are now marked for translation. Easing customization of error
messages to be done separately.
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:6>
Django
Reporter: Anton Bazhanov | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* owner: Anton Bazhanov => (none)
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:7>
Django
Reporter: Anton Bazhanov | Owner: (none)
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
--------------------------------------+------------------------------------
Changes (by Claude Paroz):
* easy: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:8>
Django
Reporter: Anton Bazhanov | Owner: Sagar
Type: | Gajare
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Sagar Gajare):
* cc: Sagar Gajare (added)
* owner: (none) => Sagar Gajare
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:9>
Django
Reporter: Anton Bazhanov | Owner: Sagar
Type: | Gajare
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Shivan Sivakumaran):
Does this still need work?
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:10>
Django
Reporter: Anton Bazhanov | Owner: Sagar
Type: | Gajare
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak):
Replying to [comment:10 Shivan Sivakumaran]:
> Does this still need work?
Yes, see [https://code.djangoproject.com/ticket/27505#comment:6 comment]:
> ''... Easing customization of error messages to be done separately.''
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:11>
Django
Reporter: Anton Bazhanov | Owner: (none)
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
--------------------------------------+------------------------------------
* owner: Sagar Gajare => (none)
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:12>
Django
Reporter: Anton Bazhanov | Owner: Pedro
Type: | Magno Müller
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* owner: (none) => Pedro Magno Müller
* status: new => assigned
Comment:
Hi, I'm a new contributor and I'd love to give it a try
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:13>
Django
Reporter: Anton Bazhanov | Owner: Pedro
Type: | Magno Müller
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Aman Pandey):
Replying to [comment:13 Pedro Magno Müller]:
> Hi, I'm a new contributor and I'd love to give it a try
hi are you still working on it or may i take the issue?
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:14>
Django
Reporter: Anton Bazhanov | Owner: Aman
Type: | Pandey
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* owner: Pedro Magno Müller => Aman Pandey
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:15>
Django
Reporter: Anton Bazhanov | Owner: Aman
Type: | Pandey
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Aman Pandey):
don't we have a workaround for that like directly import
"PageNotAnInteger" and "EmptyPage" Exceptions directly and user them in
our logic isn't it , a way to customization .?
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:16>
Django
Reporter: Anton Bazhanov | Owner: Aman
Type: | Pandey
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Uzair Ali):
Replying to [comment:14 Aman Pandey]:
> Replying to [comment:13 Pedro Magno Müller]:
> > Hi, I'm a new contributor and I'd love to give it a try
> hi are you still working on it or may i take the issue?
Hello, Can i take this up?
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:17>
Django
Reporter: Anton Bazhanov | Owner: Aman
Type: | Pandey
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Aman Pandey):
surReplying to [comment:17 Uzair Ali]:
> Replying to [comment:14 Aman Pandey]:
> > Replying to [comment:13 Pedro Magno Müller]:
> > > Hi, I'm a new contributor and I'd love to give it a try
> > hi are you still working on it or may i take the issue?
>
> Hello, Can i take this up?
yea sure but can we work together like ?
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:18>
Django
Reporter: Anton Bazhanov | Owner: Aman
Type: | Pandey
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by arischow):
I am unsure if this customisation is needed anymore as currently, all
usages of `Paginator.validate_number` will have a try/except block to
catch the `ValueError` exception and set it as `1`.
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:19>
Django
Reporter: Anton Bazhanov | Owner: Marcelo
Type: | Galigniana
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* owner: Aman Pandey => Marcelo Galigniana
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/16746 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:20>
Django
Reporter: Anton Bazhanov | Owner: Marcelo
Type: | Galigniana
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
* needs_docs: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:21>
Django
Reporter: Anton Bazhanov | Owner: Marcelo
Type: | Galigniana
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
* needs_docs: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:22>
Django
Reporter: Anton Bazhanov | Owner: Marcelo
Type: | Galigniana
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:23>
Django
Reporter: Anton Bazhanov | Owner: Marcelo
Type: | Galigniana
Component: Core (Other) | Version: dev
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"dfc720c521062cdefd64bc48a11838b0fa583439" dfc720c]:
{{{
#!CommitTicketReference repository=""
revision="dfc720c521062cdefd64bc48a11838b0fa583439"
Fixed #27505 -- Allowed customizing Paginator's error messages.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27505#comment:24>